Skip to content

Clarify language on SIG PM participation #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2018
Merged

Clarify language on SIG PM participation #2289

merged 2 commits into from
Jun 21, 2018

Conversation

@justaugustus
Copy link
Member

@justaugustus justaugustus commented Jun 19, 2018 •
edited
Loading

There is mention in a few places about the role of a SIG PM representative, which isn't actually a role that needs to be staffed.
This led to some confusion on my part (#2130), as well as an attempt to update the currently outdated list (#2122).

After some discussion in SIG PM, we decided to remove the SIG PM list and cleanup / clarify the language around SIG PM participation.

Hopefully, this:

/cc @calebamiles @idvoretskyi @jdumars

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/pm labels Jun 19, 2018
idvoretskyi
idvoretskyi approved these changes Jun 20, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2018
@justaugustus
Copy link
Member Author

/assign @jdumars @cblecker

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2018
cblecker
cblecker approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

Is there any other review that needs to go into this?

sig-governance.md Outdated
* identify SIG annual roadmap
* identify all SIG features in the current release
* actively track / maintain SIG features within [k/features](https://github.com/kubernetes/features)
* attend [SIG PM](sig-pm/README.md) meetings, as needed / requested
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this link should be /sig-pm/README.md (note the leading slash)

sig-governance.md Outdated
## SIG Roles

Defining SIG Roles is a function of the SIG Charter.
Guidelines for drafting a SIG Charter can be found [here](committee-steering/governance/README.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this link should be /committee-steering/governance/README.md (note the leading slash)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2018
@justaugustus
Remove outdated SIG Representatives list
055b49d 
Signed-off-by: Stephen Augustus <foo@agst.us>
@justaugustus
Clarify language on SIG PM participation in sig-governance.md
9a5e480 
Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2018
@justaugustus
Copy link
Member Author

@cblecker I fixed the nits. No other reviews required as @idvoretskyi approved already.
/lgtm
/hold cancel

@k8s-ci-robot
Copy link
Contributor

@justaugustus: you cannot LGTM your own PR.

In response to this:

@cblecker I fixed the nits. No other reviews required as @idvoretskyi approved already.
/lgtm
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2018
@justaugustus
Copy link
Member Author

Sorry @k8s-ci-robot; I knew that.
@idvoretskyi can you re-/lgtm this?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2018
idvoretskyi
idvoretskyi approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit a8385c0 into kubernetes:master Jun 21, 2018
@castrojo castrojo mentioned this pull request Oct 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker cblecker approved these changes

@calebamiles calebamiles Awaiting requested review from calebamiles

@jdumars jdumars Awaiting requested review from jdumars

+1 more reviewer

@idvoretskyi idvoretskyi idvoretskyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@idvoretskyi idvoretskyi

@jdumars jdumars

@cblecker cblecker

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define responsibilities of a SIG PM representative Update SIG PM Representatives list

5 participants

@justaugustus @k8s-ci-robot @idvoretskyi @cblecker @jdumars