New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Support for Kubernetes (CRD + External Controller) #543

Closed
xing-yang opened this Issue Jan 19, 2018 · 20 comments

Comments

Projects
None yet
9 participants
@xing-yang

xing-yang commented Jan 19, 2018

Feature Description

  • One-line feature description (can be used as a release note): Snapshot/restore functionality for Kubernetes and CSI. This provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers.
  • Primary contact (assignee): @jingxu97 @xing-yang
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): kubernetes/community#2335
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @saad-ali
    @jsafrane
  • Approver (likely from SIG/area to which feature belongs):
    @thockin
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.12
    • Beta release target (x.y): 1.13
    • Stable release target (x.y): 1.14
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 19, 2018

@xing-yang: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

Feature Description

  • One-line feature description (can be used as a release note): Move snapshot support in-tree.
  • Primary contact (assignee): @jingxu97 @xing-yang
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): kubernetes/community#1624
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @saad-ali
    @jsafrane
  • Approver (likely from SIG/area to which feature belongs):
    @thockin
  • Feature target (which target equals to which milestone):
  • Alpha release target (x.y): 1.10
  • Beta release target (x.y): 1.11
  • Stable release target (x.y): 1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang

This comment has been minimized.

xing-yang commented Jan 19, 2018

@kubernetes/sig-storage-feature-requests

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 19, 2018

@xing-yang: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

@kubernetes/sig-storage-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Jan 22, 2018

@saad-ali

This comment has been minimized.

Member

saad-ali commented Feb 16, 2018

We're moving this to 1.11. For this quarter the focus is on coming up with a Restore API and CSI implementation (both out-of-tree)

@mlmhl

This comment has been minimized.

mlmhl commented Mar 29, 2018

Do we have any plan for this feature in 1.11? @saad-ali @jingxu97 @xing-yang

@xing-yang

This comment has been minimized.

xing-yang commented Mar 29, 2018

@mlmhl We'll discuss about it in today's sig-storage planning meeting and make a decision.

@xing-yang

This comment has been minimized.

xing-yang commented Mar 30, 2018

@mlmhl We have agreed to work on this and target for 1.11 Alpha.

@mlmhl

This comment has been minimized.

mlmhl commented Mar 30, 2018

Thanks @xing-yang . My team is very looking forward to this feature, and I can help to move along this feature if you needed.

@xing-yang

This comment has been minimized.

xing-yang commented Mar 30, 2018

Thanks @mlmhl! I'll keep that in mind.

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Apr 12, 2018

@xing-yang @saad-ali @kubernetes/sig-storage-feature-requests can you confirm that this feature is planned for 1.11?

/cc @justaugustus

@xing-yang

This comment has been minimized.

xing-yang commented Apr 12, 2018

@idvoretskyi Yes, we are targeting this feature for 1.11.

@saad-ali saad-ali modified the milestones: next-milestone, v1.11 Apr 12, 2018

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@xing-yang @jingxu97 please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@xing-yang

This comment has been minimized.

xing-yang commented May 31, 2018

@mistyhacks We are delaying this to 1.12. Thanks.

@mistyhacks

This comment has been minimized.

mistyhacks commented May 31, 2018

@idvoretskyi idvoretskyi modified the milestones: v1.11, v1.12 Jun 1, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@xing-yang @jingxu97 @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@tpepper

This comment has been minimized.

Contributor

tpepper commented Jul 24, 2018

Is this still targeting 1.12, or does moving to CRD slow and put the implementation at risk?

@xing-yang

This comment has been minimized.

xing-yang commented Jul 25, 2018

@tpepper @justaugustus Yes, this is still targeting 1.12. Thanks.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 25, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

@saad-ali saad-ali changed the title from Move Snapshot Support in-tree to Snapshot Support for Kubernetes (CRD + External Controller) Jul 27, 2018

@saad-ali

This comment has been minimized.

Member

saad-ali commented Jul 27, 2018

Looks like this is a duplicate of #177

Closing this issue. Please put further updates on #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment