Skip to content

CSR v1 details, Approved/Denied/Failed conditions #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2020
Merged

CSR v1 details, Approved/Denied/Failed conditions #1691

merged 2 commits into from
May 11, 2020

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Apr 16, 2020

/sig auth
/assign @mikedanese @deads2k
/cc @munnerz

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Apr 16, 2020
@k8s-ci-robot k8s-ci-robot requested a review from munnerz April 16, 2020 00:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2020
@liggitt liggitt force-pushed the csr-status branch 3 times, most recently from 13f4b6b to 6593581 Compare April 16, 2020 01:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2020
@liggitt liggitt mentioned this pull request Apr 20, 2020
Closed
deads2k
deads2k reviewed Apr 20, 2020
View reviewed changes
deads2k
deads2k reviewed Apr 20, 2020
View reviewed changes
deads2k
deads2k reviewed Apr 20, 2020
View reviewed changes
deads2k
deads2k reviewed Apr 20, 2020
View reviewed changes
deads2k
deads2k reviewed Apr 20, 2020
View reviewed changes
deads2k
deads2k reviewed Apr 20, 2020
View reviewed changes
mikedanese
mikedanese reviewed Apr 20, 2020
View reviewed changes
@liggitt liggitt mentioned this pull request Apr 27, 2020
Closed
enj
enj approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@mikedanese mikedanese mentioned this pull request May 4, 2020
Merged
munnerz
munnerz reviewed May 5, 2020
View reviewed changes
@liggitt
Copy link
Member Author

liggitt commented May 7, 2020

@deads2k @mikedanese @enj @munnerz - addressed comments in standalone commit, PTAL

@liggitt
Copy link
Member Author

liggitt commented May 7, 2020

/hold for #1691 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@enj
Copy link
Member

enj commented May 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2020
@liggitt liggitt mentioned this pull request May 8, 2020
Closed
@deads2k
Copy link
Contributor

deads2k commented May 8, 2020

/lgtm

@mikedanese
Copy link
Member

mikedanese commented May 11, 2020

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit bde2898 into kubernetes:master May 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 11, 2020
@liggitt liggitt deleted the csr-status branch May 12, 2020 21:47
RomanBednar pushed a commit to RomanBednar/enhancements that referenced this pull request Nov 8, 2024
@openshift-merge-bot
Merge pull request kubernetes#1691 from deads2k/featuregates-disable
8f42c2d 
enable, then disable featuregates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@enj enj enj approved these changes

+2 more reviewers

@munnerz munnerz munnerz left review comments

@mikedanese mikedanese mikedanese left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mikedanese mikedanese

@enj enj

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.19

Development

Successfully merging this pull request may close these issues.

6 participants

@liggitt @k8s-ci-robot @enj @deads2k @mikedanese @munnerz