Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add KEP-2227 for default container used by kubectl #2189

Merged
merged 1 commit into from
Feb 5, 2021
Merged

add KEP-2227 for default container used by kubectl #2189

merged 1 commit into from
Feb 5, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Dec 16, 2020 •
edited
Loading

#2227 is the issue to track this feature.

I opened kubernetes/kubernetes#97099
Fixes kubernetes/kubernetes#96986, a similar solution like kubernetes/kubernetes#87809

There is a discussion in #95293 which is in process for generic default container.

Users might specify the `kubectl.kubernetes.io/default-container` annotation in a Pod to preselect container for kubectl commands.

@mfojtik & @howardjohn
@dougsland @eddiezane @soltysh

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Dec 16, 2020
@pacoxu pacoxu mentioned this pull request Dec 16, 2020
Merged
@pacoxu
Copy link
Member Author

pacoxu commented Dec 24, 2020 •
edited
Loading

@dougsland I have removed the initial proposal.

The code kubernetes/kubernetes#97099 is updated as well.

dougsland
dougsland reviewed Jan 2, 2021
View reviewed changes
Copy link
Member

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments and a question is this updated with the latest KEP template (Example: I see missing Drawback)?
https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md

keps/sig-cli/20201216-kubectl-default-container.md Outdated Show resolved Hide resolved
keps/sig-cli/20201216-kubectl-default-container.md Outdated Show resolved Hide resolved
keps/sig-cli/20201216-kubectl-default-container.md Outdated Show resolved Hide resolved
@dougsland
Copy link
Member

not sure if you opened an issue in kep kubernetes/enhancements/issues but looks like it's required for tracking.

@pacoxu pacoxu mentioned this pull request Jan 3, 2021
Closed
13 tasks
@pacoxu
Copy link
Member Author

pacoxu commented Jan 3, 2021

@deads2k @johnbelamaric @wojtek-t
I'm not sure who can be added as approver for this KEP.

@pacoxu
Copy link
Member Author

pacoxu commented Jan 3, 2021

Few comments and a question is this updated with the latest KEP template (Example: I see missing Drawback)?
https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md

I try to follow the new KEP template and add #2227 for tracking.

@pacoxu
Copy link
Member Author

pacoxu commented Jan 3, 2021

/assign @johnbelamaric @seans3

@pacoxu pacoxu requested a review from dougsland January 5, 2021 06:37
@dougsland
Copy link
Member

more people need to review this one. Please squash the commits.

soltysh
soltysh reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but this looks good overall.

keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
@pacoxu
Copy link
Member Author

pacoxu commented Feb 4, 2021

@soltysh @rikatz Thanks for your review. Updated per your comments.

@pacoxu pacoxu requested review from rikatz and soltysh February 4, 2021 03:00
rikatz
rikatz reviewed Feb 4, 2021
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pacoxu some small nits, overall lgtm :)

keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
soltysh
soltysh approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
@pacoxu get the last bits fixed and pls squash it all into a sigle commit.

keps/sig-cli/2227-kubectl-default-container/README.md Outdated Show resolved Hide resolved
@soltysh
Copy link
Contributor

soltysh commented Feb 4, 2021

/assign

@deads2k
Copy link
Contributor

deads2k commented Feb 4, 2021

some PRR nits, the PRR looks ok otherwise.

@johnbelamaric
Copy link
Member

PRR looks good except you can fix David's nits. I won't approve yet though because it will approve everything; I will wait on SIG approval before putting in my approve for PRR.

@rikatz
Copy link
Contributor

rikatz commented Feb 5, 2021

@johnbelamaric there's already approval from @soltysh :)

@pacoxu pacoxu requested a review from deads2k February 5, 2021 02:28
@pacoxu
Copy link
Member Author

pacoxu commented Feb 5, 2021

Thanks for your review. @deads2k updated per your comments. Add questions and simple answers for Dependencies/Scalability.

@deads2k
Copy link
Contributor

deads2k commented Feb 5, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
deads2k
deads2k reviewed Feb 5, 2021
View reviewed changes
keps/prod-readiness/sig-cli/2227.yaml Outdated
@@ -0,0 +1,3 @@
kep-number: 2227
alpha:
approver: "@johnbelamaric"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you get to it before your PR is lgtm'd by sig-cli, this ought to be @deads2k

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll wait with tagging this for that having fixed.

soltysh
soltysh approved these changes Feb 5, 2021
View reviewed changes
keps/prod-readiness/sig-cli/2227.yaml Outdated
@@ -0,0 +1,3 @@
kep-number: 2227
alpha:
approver: "@johnbelamaric"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll wait with tagging this for that having fixed.

@wojtek-t @pacoxu
use generic default container annotations for kubectl
0ae8e51 
Co-authored-by: rikatz <ricardo.katz@gmail.com>
Co-authored-by: wojtekt <wojtekt@google.com>

sd
soltysh
soltysh approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, pacoxu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 90a81bc into kubernetes:master Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 5, 2021
@mengjiao-liu mengjiao-liu mentioned this pull request Mar 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@rikatz rikatz rikatz left review comments

@deads2k deads2k deads2k left review comments

@soltysh soltysh soltysh approved these changes

@eddiezane eddiezane Awaiting requested review from eddiezane

@dougsland dougsland Awaiting requested review from dougsland

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@soltysh soltysh

@seans3 seans3

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Add exec equivalent to kubectl.kubernetes.io/default-logs-container