Skip to content

Conversation

@seans3
Copy link
Contributor

@seans3 seans3 commented Oct 16, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2025
@seans3
Copy link
Contributor Author

seans3 commented Oct 21, 2025

/assign @janetkuo

# 1 billion parameter model (smallest gemma model)
- name: MODEL_ID
value: google/gemma-3-1b-it
# Fixes - https://github.com/vllm-project/vllm/issues/18859
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the information here meaningful to users? Is LD_LIBRARY_PATH only needed for certain version of vLLM? If so, that kind of information is good to capture here.

Copy link
Contributor Author

@seans3 seans3 Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I've added the versions of the image that this is needed for. I've kept a reference to the issue, in case users need to do more research. Please let me know what you think.

@seans3 seans3 force-pushed the container-image-fix branch from 7cbcf02 to a0ed769 Compare October 21, 2025 21:08
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0b0f2eb into kubernetes:master Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants