Skip to content

Update RELEASING doc #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jun 24, 2021
Merged

Update RELEASING doc #426

k8s-ci-robot merged 1 commit into from
Jun 24, 2021

Conversation

@thockin
Copy link
Member

@thockin thockin commented Jun 24, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2021
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip June 24, 2021 16:02
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2021
nan-yu
nan-yu approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@nan-yu nan-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the release note.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nan-yu
Copy link
Contributor

nan-yu commented Jun 24, 2021

@thockin Can you grant me access to the k8s-staging-git-sync project? I'm having permission issue when trying to push an image.

denied: Token exchange failed for project 'k8s-staging-git-sync'. Caller does not have permission 'storage.buckets.get'. To configure permissions, follow instructions at: https://cloud.google.com/container-registry/docs/access-control

@nan-yu
Copy link
Contributor

nan-yu commented Jun 24, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit fc7162b into kubernetes:release-3.x Jun 24, 2021
@thockin
Copy link
Member Author

thockin commented Jun 24, 2021

Regarding permissions: kubernetes/k8s.io#2264 was still held - my fault. Should merge and reconcile soon.

What are you pushing up there? Just trying it out or doing something with it?

@nan-yu
Copy link
Contributor

nan-yu commented Jun 24, 2021

I was just trying out the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stp-ip stp-ip Awaiting requested review from stp-ip

1 more reviewer

@nan-yu nan-yu nan-yu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@janetkuo janetkuo

@nan-yu nan-yu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thockin @k8s-ci-robot @nan-yu @janetkuo