Small nits I found with password-file while porting #431#436
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jul 6, 2021
Merged
Small nits I found with password-file while porting #431#436k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Forgot the manual entry for it, tweaked some words.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
thockin
changed the title
|
Thanks for the generous effort! (and sorry I didn't make it perfect the first time.) |
Member
Author
|
Not at all. My fault for reviewing in haste
…On Mon, Jul 5, 2021, 9:10 PM zhouhaibing089 ***@***.***> wrote:
Thanks for the generous effort! (and sorry I didn't make it perfect the
first time.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVFTFEUAMQNOFNJG3FTTWJ63XANCNFSM473OBRTQ>
.
|
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot the manual entry for it, tweaked some words.