Skip to content

E2E Overhaul (v4)#448

Merged
thockin merged 9 commits intokubernetes:masterfrom
thockin:e2e-cleanup
Oct 18, 2021
Merged

E2E Overhaul (v4)#448
thockin merged 9 commits intokubernetes:masterfrom
thockin:e2e-cleanup

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Oct 6, 2021

This overhauls the e2e testing to:

a) Improve readability
b) Allow to run individual tests
c) Better handle ^C interruption

This is best reviewed commit-by-commit witch whitespace ignored.

Example:

$ ./test_e2e.sh -?
available tests:
    head_once_root_doesnt_exist
    head_once_root_exists_empty
    head_once_root_flag_is_weird
    head_once_root_flag_has_symlink
    non_zero_exit
    head_once_root_exists_but_is_not_git_root
    head_once_root_exists_but_fails_sanity
    default_sync_master
    head_sync
    worktree_cleanup
    readlink
    branch_sync
    branch_switch
    tag_sync
    tag_sync_annotated
    rev_sync
    rev_once
    crash_cleanup_retry
    sync_loop_timeout
    depth
    fetch_skip_depth_1
    password
    askpass_url
    exechook_success
    exechook_fail_retry
    webhook_success
    webhook_fail_retry
    webhook_fire_and_forget
    http
    submodule_sync
    submodule_sync_depth
    submodule_sync_off
    submodule_sync_shallow
    ssh
    sparse_checkout
    additional_git_configs
    export_error
    github_https

$ ./test_e2e.sh head_sync
making bin/linux_amd64/git-sync
container: e2e/git-sync:v3.2.1-134-g06aad1d__linux_amd64

<docker  build output>

test root is /tmp/git-sync-e2e.1580322924

testcase head_sync: PASS

all tests passed: cleaning up /tmp/git-sync-e2e.1580322924

This builds on and includes #446

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip October 6, 2021 18:13
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2021
@kubernetes kubernetes deleted a comment from k8s-triage-robot Oct 8, 2021
Make all test cases functions so they can be called individually on the
CLI.  Call test_e2e.sh with `-?` to list tests.   Fix related crashes
(uses of $TESTCASE and so on).
Reduce the diff between v3 and v4
@thockin
Copy link
Copy Markdown
Member Author

thockin commented Oct 18, 2021

self-merge

@thockin thockin merged commit 2b471ba into kubernetes:master Oct 18, 2021
@thockin thockin deleted the e2e-cleanup branch February 25, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants