Skip to content

Don't double-register the hook metric (v4)#476

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4-double-register-hook-metric
Jan 23, 2022
Merged

Don't double-register the hook metric (v4)#476
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4-double-register-hook-metric

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Jan 22, 2022

xref #474

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip January 22, 2022 22:27
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2022
@thockin thockin changed the title Don't double-register the hook metric Don't double-register the hook metric (v4) Jan 22, 2022
Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 10fd8e6 into kubernetes:master Jan 23, 2022
@thockin thockin deleted the v4-double-register-hook-metric branch February 25, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants