Allow --dest to be an absolute path (v4)#478
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 23, 2022
Merged
Conversation
This means it might live outside of --root.
thockin
changed the title
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
approved
stp-ip
approved these changes
Jan 23, 2022
Member
stp-ip
left a comment
stp-ip
left a comment
There was a problem hiding this comment.
/lgtm
First time I noticed due to the addition of spaces that was made as well.
Why do we use double spaces after periods? Or just a habit? Nothing to block for so merging.
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
It was inconsistent in the file. It used to be the norm to use 2 spaces
after periods, which is how I learned. I don't care either way, just
wanted consistency. :)
…On Sun, Jan 23, 2022, 2:42 AM Kubernetes Prow Robot < ***@***.***> wrote:
Merged #478 <#478> into master.
—
Reply to this email directly, view it on GitHub
<#478 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVBS3T6VHJPGJP5SRCDUXPLP7ANCNFSM5MTAPVJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means it might live outside of --root.
xref #428