Skip to content

v4: Bring some Makefile cleanups from k/k#566

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4_makefile_dbg
Jul 4, 2022
Merged

v4: Bring some Makefile cleanups from k/k#566
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4_makefile_dbg

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Jul 3, 2022

Dep on #564

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip July 3, 2022 20:24
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2022
Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2022
@thockin thockin force-pushed the v4_makefile_dbg branch from d0d8cde to 9d52a21 Compare July 3, 2022 23:51
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2022
@thockin
Copy link
Copy Markdown
Member Author

thockin commented Jul 3, 2022

rebased

Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 42d292d into kubernetes:master Jul 4, 2022
@thockin thockin deleted the v4_makefile_dbg branch February 25, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants