Skip to content

v4: e2e: Fix ncsvr to wait for input on HTTP#568

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4_ncsvr_http_bug
Jul 7, 2022
Merged

v4: e2e: Fix ncsvr to wait for input on HTTP#568
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4_ncsvr_http_bug

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Jul 3, 2022

This caused occasional e2e flakes when the server responded before the
client request had been sent.

This caused occasional e2e flakes when the server responded before the
client request had been sent.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip July 3, 2022 20:25
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2022
Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 37eba71 into kubernetes:master Jul 7, 2022
@thockin thockin deleted the v4_ncsvr_http_bug branch February 25, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants