Skip to content

v4: Don't set known_hosts to /dev/null #586

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4_known_hosts_not_dev_null
Jul 14, 2022
Merged

v4: Don't set known_hosts to /dev/null #586
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4_known_hosts_not_dev_null

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Jul 3, 2022 •
edited
Loading

Dep #584

xref #555

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip July 3, 2022 20:37
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2022
stp-ip
stp-ip approved these changes Jul 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Copy Markdown
Member Author

thockin commented Jul 14, 2022

This is inclusive of all the pending v4 commits - if you LGTM this I can do the rebase and self-lgtm on each intermediate PR, to save you time

@thockin thockin force-pushed the v4_known_hosts_not_dev_null branch from 25036a6 to 97f7239 Compare July 14, 2022 17:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2022
@thockin
Don't set known_hosts to /dev/null
058ccea 
This causes git to log, repeatedly, that it is "adding to known hosts".
@thockin thockin force-pushed the v4_known_hosts_not_dev_null branch from 97f7239 to 058ccea Compare July 14, 2022 17:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022
@thockin
Copy link
Copy Markdown
Member Author

thockin commented Jul 14, 2022

Rebased

@stp-ip
Copy link
Copy Markdown
Member

stp-ip commented Jul 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit c62f6cb into kubernetes:master Jul 14, 2022
@thockin thockin deleted the v4_known_hosts_not_dev_null branch February 25, 2023 22:43
@p-linnane p-linnane mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stp-ip stp-ip stp-ip approved these changes

@nan-yu nan-yu Awaiting requested review from nan-yu

Assignees

@stp-ip stp-ip

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thockin @k8s-ci-robot @stp-ip