Skip to content

Allow flags to have multiple env var names#618

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:fix-env-var-names
Aug 30, 2022
Merged

Allow flags to have multiple env var names#618
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:fix-env-var-names

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Aug 21, 2022

Anything but the 0th name is considered deprecated.

Fixes #290

Anything but the 0th name is considered deprecated.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip August 21, 2022 00:35
Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0c0c6f0 into kubernetes:master Aug 30, 2022
@thockin thockin deleted the fix-env-var-names branch February 25, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some env vars are named inconsistently

3 participants