Skip to content

Do print-and-exit flags before logging#638

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4-print-exit-flags-before-logs
Oct 31, 2022
Merged

Do print-and-exit flags before logging#638
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thockin:v4-print-exit-flags-before-logs

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Oct 30, 2022

Minor cleanup

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip October 30, 2022 23:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2022
Copy link
Copy Markdown
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ca48f8 into kubernetes:master Oct 31, 2022
@thockin thockin deleted the v4-print-exit-flags-before-logs branch February 25, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants