Add a test to exercise git#680
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 17, 2023
Merged
Conversation
I keep having to cross-check whether things work the way I think they work. I am codifying them into a test.
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Member
|
Am I missing something or is this mostly for running it manually within a manually spun up container? |
Member
Author
|
I was trying to make it simple - something I could quickly run to confirm
behavior rather than manual tests. I left a TODO to containerize it, but
it is mostly aimed at me while I'm doing a large PR for V4.
…On Fri, Feb 17, 2023, 5:43 AM Michael Grosser ***@***.***> wrote:
Am I missing something or is this mostly for running it manually within a
manually spun up container?
Any reason to not run this alongside the e2e tests?
—
Reply to this email directly, view it on GitHub
<#680 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVEWPPUORSEFCUHBXDTWX5577ANCNFSM6AAAAAAU6U34JA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Yeah saw the TODO, just wanted to check in, that I didn't miss anything. /lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
I'm working on a big one and I am trying to make it as contained as possible by peeling off anything I can :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I keep having to cross-check whether things work the way I think they work. I am codifying them into a test.