Skip to content

Add an abspath type#728

Merged
thockin merged 2 commits intokubernetes:masterfrom
thockin:v4_abspath_type
May 5, 2023
Merged

Add an abspath type#728
thockin merged 2 commits intokubernetes:masterfrom
thockin:v4_abspath_type

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented May 5, 2023

Add an absPath type and use it for git.root
Use absPath type for link and touchfile

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip May 5, 2023 00:48
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2023
@thockin thockin changed the title V4 abspath type Add an abspath type May 5, 2023
@thockin
Copy link
Copy Markdown
Member Author

thockin commented May 5, 2023

self-merge to fix build - I reordered commits wrongly

@thockin thockin merged commit e033732 into kubernetes:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants