-
Notifications
You must be signed in to change notification settings - Fork 935
Add cert monitor manifest #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| namespace: cert-manager | ||
| --- | ||
| apiVersion: apps/v1 | ||
| kind: Deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love some comments (yay YAML, you beat JSON at something) to explain what's going on. Or a README-ish file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make both :)
Put some comments on the YAML, at least about the prometheus and sdexporter configuration, and write on the README (I've already added a README on the another PR)
|
@thockin added some limits, some comments, some security context :) Tested in my cluster and worked fine, hopefully this is the first step to renew the certificates before anything blows. Next step: I'll check a way to automate the dashboard and alerting (there's an issue assigned to me anyway) so we can somehow automate everything. |
|
Checking in... do we still need this? I admit I have kinda lost track at where we are with using cert-manager vs. GKE managed certificates these days |
|
/close As we discussed, per migration to Google managed certificates this is not necessary anymore :) |
|
@rikatz: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cert-monitor will read the metrics from cert-manager prometheus exporter, transform it into days and push to stackdriver.
TODO: