Skip to content

Conversation

@ameukam
Copy link
Member

@ameukam ameukam commented Jun 3, 2021

Ref: #1943

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Ref: kubernetes#1943

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra wg/reliability Categorizes an issue or PR as relevant to WG Reliability approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2021
@ameukam ameukam marked this pull request as ready for review June 4, 2021 22:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Jun 7, 2021

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 053994d into kubernetes:main Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 7, 2021
@ameukam
Copy link
Member Author

ameukam commented Jun 7, 2021

Certificate sucessfully deployed:

openssl s_client -connect sippy.k8s.io:443
CONNECTED(00000003)
depth=2 C = US, O = Internet Security Research Group, CN = ISRG Root X1
verify return:1
depth=1 C = US, O = Let's Encrypt, CN = R3
verify return:1
depth=0 CN = sippy.k8s.io
verify return:1

https://ssllabs.com/ssltest/analyze.html?d=sippy.k8s.io

@ameukam
Copy link
Member Author

ameukam commented Jun 7, 2021

xref: #1900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/reliability Categorizes an issue or PR as relevant to WG Reliability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants