fix: apply gofmt formatting to package doc comment in klog.go

[pierluigilenoci]

Summary

Fix mixed tab/space indentation in the package doc comment of klog.go (lines 59-105) introduced by #432, which caused the golangci-lint gofmt check to fail in CI.

To prevent this from happening again, a separate PR has been submitted to add lint as a required status check in Prow branch protection: kubernetes/test-infra#36671.

Root cause

See root cause analysis comment for details on why PR #432's pipeline didn't catch the formatting error.

Test plan

• gofmt -d klog.go shows no diff
• go build ./... compiles successfully

[k8s-ci-robot]

This issue is currently awaiting triage.

If klog contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierluigilenoci]

@pohly @harshanarayana please take a look

[pierluigilenoci]

Root cause analysis: why PR #432's pipeline didn't catch the formatting errors

1. Lint workflow never ran on PR #432 (primary cause)

PR #432 was opened from a fork (pierluigilenoci/klog → kubernetes/klog). For fork PRs, GitHub Actions requires maintainer approval before executing workflows (security measure to prevent arbitrary code execution).

Evidence from the workflow run history:

• There is no pull_request event run for the fix/stderr-threshold-issue-212 branch
• PRs from internal branches (e.g. textlogger-optional-header by @pohly) all have lint pull_request runs → success
• PR fix: apply gofmt formatting to package doc comment in klog.go #435 (this one) also shows conclusion: action_required — waiting for maintainer approval to run

The lint only executed after the merge, on the push event to main (2026-03-03), where it failed — but by then the PR was already merged.

2. Lint is not a required check for Prow/Tide

The kubernetes/klog repo uses Prow/Tide (k8s-ci-robot) for automated merging. Tide has its own list of required checks, configured in the kubernetes/test-infra repo. The GitHub Actions "Run lint" workflow is not listed as a required check for Tide. So even if the lint had run and failed, Tide would have still merged the PR as long as it had the lgtm + approved labels.

Timeline summary

Event	Lint status
PR #432 opened (2025-12-15)	Not executed (fork PR, requires maintainer approval)
PR #432 merged by Tide (2026-03-03)	Merged with lgtm + approved only
Push to main (2026-03-03)	Lint executed → FAILURE (gofmt)
PR #435 opened	Fixes the formatting error

Suggestions to prevent this in the future

1. Maintainers should approve workflow runs on fork PRs before merging
2. Add lint as a required check in the Prow/Tide configuration (kubernetes/test-infra) — submitted as kubernetes/test-infra#36671
3. Use local pre-commit hooks (as added in this PR) to catch issues before they even reach CI

[pierluigilenoci]

@pohly the PR has been updated as requested:

• Removed .pre-commit-config.yaml — the PR now only touches klog.go (gofmt fix)
• Updated title and description accordingly
• The infrastructure fix (adding lint as a required status check) is tracked separately in kubernetes/test-infra#36671, where all CI checks are passing

Could you re-review when you get a chance? Thanks!

[pohly]

Confirmed locally that gofmt is happy with this results.

Please squash into a single commit.

[pohly]

/lgtm
/approve

After kubernetes/test-infra#36671 got merged this should not merge the PR. Seems to have worked: the two lint jobs are shown as "Waiting for status to be reported" and "Required".

[pohly]

/hold

For squashing.

[pierluigilenoci]

@pohly Squashed into a single commit. PR is ready for review.

[pohly]

/lgtm
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierluigilenoci, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment