Add some clarification to KubeSchedulerConfiguration#18151
Add some clarification to KubeSchedulerConfiguration#18151k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
area/documentation
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Text only PR... |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc, pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| Fields set in `spec.kubeScheduler` (see [cluster_spec.md](cluster_spec.md#kubescheduler)) are merged on top of the KubeSchedulerConfiguration object. | ||
| This allows you to use KubeSchedulerConfiguration for advanced settings like scheduler profiles and plugins, while using `spec.kubeScheduler` for simpler fields. |
There was a problem hiding this comment.
I suspect if cluster's spec.kubeScheduler and KubeSchedulerConfiguration passed via --add are merged, it is not related to the way how we porvide this configuration - via fileAssets, in which case we must define a complete resource spec as it will be used as-is
| When creating a new cluster, you can use the `--add` flag (requires the `ClusterAddons` feature flag): | ||
|
|
||
| ``` | ||
| export KOPS_FEATURE_FLAGS=ClusterAddons | ||
| kops create cluster --name=my.cluster.k8s.local --zones us-east-2a --add scheduler-config.yaml | ||
| kops update cluster --name=my.cluster.k8s.local --yes --admin | ||
| ``` |
There was a problem hiding this comment.
I can recall sir Justin said on kubecon that resources passed via --add won't persist with subsequent cluster updates...
4 participants
Closes #18139