-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Custom Metrics in HPA doc #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @fgrzadkowski |
|
In general this lgtm, but I believe we need document somewhere what's the default behavior if nothing is specified (neither CPU utilization nor custom metrics target). |
|
@mwielgus ping |
5418a82 to
e0d6dbe
Compare
|
@fgrzadkowski pong |
| In this case if there are 4 pods running and each of them reports qps metric to be equal to 15 HPA will start 2 additional pods so there will be 6 pods in total. If there are multiple metrics passed in the annotation or CPU is configured as well then HPA will use the biggest | ||
| number of replicas that comes from the calculations. | ||
|
|
||
| At this moment even if target CPU utilization is not specified a default of 80 will be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...a default of 80% will be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
ping @mwielgus |
e0d6dbe to
131d70c
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
95ccc3c to
109138e
Compare
|
CLAs look good, thanks! |
109138e to
3115da4
Compare
|
ping @fgrzadkowski |
|
Is there an example application that implements this in the kubernetes source tree? |
|
@johndmulhausen I have just LGTMed this from technical side. What are the next steps? I'm reassigning this to you to explain next steps. |
|
ping @johndmulhausen |
|
|
||
| ## Support for custom metrics | ||
|
|
||
| Kubernetes 1.2 brings an alpha support for scaling based on application-specific metrics like QPS(Query per second) or average request latency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes {{ page.version }} adds alpha support for scaling based on application-specific metrics like QPS (queries per second) or average request latency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, however i will stick to 1.2 - so that wehn this documentation is copied to 1.3 the value is not updated.
|
@mwielgus ping |
|
@jszczepkowski pong |
|
LGTM! Merging, thanks. |
concepts-configuration-manage-compute-resources-container-pr-20170815
* Add service profile and related docs Signed-off-by: Alex Leong <alex@buoyant.io> * Spelling Signed-off-by: Alex Leong <alex@buoyant.io> * Fix formatting Signed-off-by: Alex Leong <alex@buoyant.io> * Re-order pages Signed-off-by: Alex Leong <alex@buoyant.io> * Fix whitespace Signed-off-by: Alex Leong <alex@buoyant.io> * Review feedback Signed-off-by: Alex Leong <alex@buoyant.io>
* chore: init i18n Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * docs: zh Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: imports Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * docs: remove useless Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: wrong line break Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * docs: merge latest into v2 Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: indents Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: numerous indents-related errors Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: ci Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * docs(zh): v2.0.2 Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update announcement Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update config Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * fix: inconsistent doc names Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> * chore: update Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
cc: @piosz @davidopp