Skip to content

Conversation

@mwielgus
Copy link
Contributor

@mwielgus
Copy link
Contributor Author

cc: @fgrzadkowski

@fgrzadkowski fgrzadkowski self-assigned this Mar 17, 2016
@fgrzadkowski
Copy link
Contributor

In general this lgtm, but I believe we need document somewhere what's the default behavior if nothing is specified (neither CPU utilization nor custom metrics target).

@fgrzadkowski
Copy link
Contributor

@mwielgus ping

@mwielgus
Copy link
Contributor Author

@fgrzadkowski pong

In this case if there are 4 pods running and each of them reports qps metric to be equal to 15 HPA will start 2 additional pods so there will be 6 pods in total. If there are multiple metrics passed in the annotation or CPU is configured as well then HPA will use the biggest
number of replicas that comes from the calculations.

At this moment even if target CPU utilization is not specified a default of 80 will be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...a default of 80% will be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@piosz
Copy link
Member

piosz commented Apr 23, 2016

ping @mwielgus

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@mwielgus mwielgus force-pushed the custom-metrics branch 2 times, most recently from 95ccc3c to 109138e Compare April 28, 2016 18:31
@googlebot
Copy link

CLAs look good, thanks!

@piosz
Copy link
Member

piosz commented May 4, 2016

ping @fgrzadkowski

@philips
Copy link
Contributor

philips commented May 4, 2016

Is there an example application that implements this in the kubernetes source tree?

@fgrzadkowski
Copy link
Contributor

@johndmulhausen I have just LGTMed this from technical side. What are the next steps? I'm reassigning this to you to explain next steps.

@piosz
Copy link
Member

piosz commented May 16, 2016

ping @johndmulhausen


## Support for custom metrics

Kubernetes 1.2 brings an alpha support for scaling based on application-specific metrics like QPS(Query per second) or average request latency.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes {{ page.version }} adds alpha support for scaling based on application-specific metrics like QPS (queries per second) or average request latency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, however i will stick to 1.2 - so that wehn this documentation is copied to 1.3 the value is not updated.

@jszczepkowski
Copy link
Contributor

@mwielgus ping

@mwielgus
Copy link
Contributor Author

@jszczepkowski pong

@johndmulhausen
Copy link

LGTM! Merging, thanks.

@johndmulhausen johndmulhausen merged commit 8224765 into kubernetes:master Jun 24, 2016
YuxiJin-tobeyjin pushed a commit to YuxiJin-tobeyjin/kubernetes.github.io that referenced this pull request Sep 12, 2017
concepts-configuration-manage-compute-resources-container-pr-20170815
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Feb 24, 2021
* Add service profile and related docs

Signed-off-by: Alex Leong <alex@buoyant.io>

* Spelling

Signed-off-by: Alex Leong <alex@buoyant.io>

* Fix formatting

Signed-off-by: Alex Leong <alex@buoyant.io>

* Re-order pages

Signed-off-by: Alex Leong <alex@buoyant.io>

* Fix whitespace

Signed-off-by: Alex Leong <alex@buoyant.io>

* Review feedback

Signed-off-by: Alex Leong <alex@buoyant.io>
WangXiangUSTC pushed a commit to WangXiangUSTC/website that referenced this pull request Oct 19, 2021
* chore: init i18n

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* docs: zh

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: imports

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* docs: remove useless

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: wrong line break

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* docs: merge latest into v2

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: indents

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: numerous indents-related errors

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: ci

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* docs(zh): v2.0.2

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update announcement

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update config

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* fix: inconsistent doc names

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>

* chore: update

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants