add unittest for kubelet isInitContainerFailed func

[yxxhero]

Signed-off-by: yxxhero aiopsclub@163.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

add unittest for kubelet isInitContainerFailed func

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

[k8s-ci-robot]

Hi @yxxhero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yxxhero]

/sig node

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yxxhero
To complete the pull request process, please assign sjenning after the PR has been reviewed.
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yangjunmyfm192085]

good job@yxxhero,s Could you add some abnormal tests also?
For example:

kubecontainer.Status = ContainerStateUnknown
ExitCode: 1

kubecontainer.Status = ContainerStateUnknown
ExitCode: 0

/cc @249043822

[yangjunmyfm192085]

/ok-to-test

[249043822]

/triage accepted
/priority backlog

[yxxhero]

good job@yxxhero,s Could you add some abnormal tests also?

For example:
kubecontainer.Status = ContainerStateUnknown
ExitCode: 1

kubecontainer.Status = ContainerStateUnknown
ExitCode: 0

/cc @249043822

ok, I will add it.

[yxxhero]

good job@yxxhero,s Could you add some abnormal tests also?

For example:
kubecontainer.Status = ContainerStateUnknown
ExitCode: 1

kubecontainer.Status = ContainerStateUnknown
ExitCode: 0

/cc @249043822

good job@yxxhero,s Could you add some abnormal tests also?

For example:
kubecontainer.Status = ContainerStateUnknown
ExitCode: 1

kubecontainer.Status = ContainerStateUnknown
ExitCode: 0

/cc @249043822

form source code:

	if status.State == kubecontainer.ContainerStateUnknown {
		return true
	}

I think the cases not need. what do you think of? @yangjunmyfm192085

[yangjunmyfm192085]

good job@yxxhero,s Could you add some abnormal tests also?

For example:
kubecontainer.Status = ContainerStateUnknown
ExitCode: 1
kubecontainer.Status = ContainerStateUnknown
ExitCode: 0
/cc @249043822

good job@yxxhero,s Could you add some abnormal tests also?

For example:
kubecontainer.Status = ContainerStateUnknown
ExitCode: 1
kubecontainer.Status = ContainerStateUnknown
ExitCode: 0
/cc @249043822

form source code:

	if status.State == kubecontainer.ContainerStateUnknown {
		return true
	}

I think the cases not need. what do you think of? @yangjunmyfm192085

That's right, but I hope these test cases could keep correctness of the code . and It's really good now.

[yangjunmyfm192085]

/lgtm

[manugupt1]

looks good to me.

[yxxhero]

@mrunalp Please review, Thanks very much.

[yxxhero]

@mrunalp Please review, Thanks very much.

[yxxhero]

@mrunalp ping

[yxxhero]

@mrunalp any update? Thanks very much.

[ffromani]

I'm still unsure we should test internal helpers, but it seems positive consensus already formed for this change.
Please squash your commits, keeping the first commit message. I'll add my lgtm once done

[yxxhero]

@fromanirh Thanks very much.

[ffromani]

/lgtm

[yxxhero]

/test pull-kubernetes-e2e-gce-ubuntu-containerd

[k8s-ci-robot]

@yxxhero: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.