Skip to content

remove reuse buf todo #117033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Apr 12, 2023
Merged

remove reuse buf todo #117033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0393845
reuse buf
mouuii Mar 31, 2023
d2a35c9
remove the todo
mouuii Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion staging/src/k8s.io/apimachinery/pkg/runtime/codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ func NewCodec(e Encoder, d Decoder) Codec {

// Encode is a convenience wrapper for encoding to a []byte from an Encoder
func Encode(e Encoder, obj Object) ([]byte, error) {
// TODO: reuse buffer
buf := &bytes.Buffer{}
if err := e.Encode(obj, buf); err != nil {
return nil, err
Expand Down