[release-1.31] [cloud-provider] respect the "exclude-from-external-load-balancers=false" label

[kayrus]

This is a cherry-pick of the #131085

Does this PR introduce a user-facing change?

[cloud-provider] respect the "exclude-from-external-load-balancers=false" label

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Users who previously set the `node.kubernetes.io/exclude-from-external-load-balancers` label to "false" expecting the node to remain included in external load balancers will see a behavior change with this fix. Going forward, only a value of "true" or an invalid value (including an empty string) will result in exclusion. Explicitly setting the label to "false" will correctly include the node.

[k8s-ci-robot]

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elmiko]

/triage accepted

[elmiko]

/approve
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: b6f7a4dfac8884a3e11d7c42cac9b2eb7a009cbf

[dims]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, elmiko, kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• staging/src/k8s.io/cloud-provider/controllers/service/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elmiko]

/cc kubernetes/release-managers

[elmiko]

/hold

i think we might have moved to quickly with this backport, it might not be appropriate.

[elmiko]

after further discussion it would appear that this is not a good candidate for backport.

/close

[k8s-ci-robot]

@elmiko: Closed this PR.

Details

In response to this:

after further discussion it would appear that this is not a good candidate for backport.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.