-
Notifications
You must be signed in to change notification settings - Fork 41.8k
Fix pod resize validation when adding non-resizable resources #135084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
cc438ba to
9dabd07
Compare
9dabd07 to
9b95eaf
Compare
| } | ||
| resp.Spec.Containers[0].Resources = v1.ResourceRequirements{ | ||
| Requests: v1.ResourceList{ | ||
| v1.ResourceEphemeralStorage: resource.MustParse("2Gi"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny that we had a test verifying the incorrect behavior... 🤔
natasha41575
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 595e37bc25e9e6185fedd9dfe85d8701e5c3f483
|
|
/assign @liggitt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tallclair: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest-required |
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
While reviewing #132919 I noticed a bug in ValidatePodResize: if a container doesn't have any resources, you can add any resources other than CPU & memory.
Special notes for your reviewer:
This change is a candidate for backport.
This method could use some more cleanup, but I'm trying to keep the diff minimal.
Does this PR introduce a user-facing change?
/sig node
/priority important-soon
/assign @natasha41575