Skip to content

Support completions for kubectl config rename-context #48340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2017
Merged

Support completions for kubectl config rename-context #48340

merged 1 commit into from
Nov 10, 2017

Conversation

superbrothers
Copy link
Member

@superbrothers superbrothers commented Jun 30, 2017 •
edited
Loading

What this PR does / why we need it:
With this PR, kubectl config rename-context supports completion for current context.

$ kubectl config rename-context <tab>
cluster01  minikube

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Support completion for kubectl config rename-context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @superbrothers. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 30, 2017
@spiffxp
Copy link
Contributor

spiffxp commented Jun 30, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2017
@dims
Copy link
Member

dims commented Jul 1, 2017

/assign @smarterclayton

@dims
Copy link
Member

dims commented Jul 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2017
@dims
Copy link
Member

dims commented Jul 1, 2017

/approve

@superbrothers
Copy link
Member Author

@dims Thank you for your approval. However you might need to write /approve no-issue in a comment in order to merge this PR.

@dims
Copy link
Member

dims commented Jul 17, 2017

/retest

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 96 hours old. Re-running tests.

@dims
Copy link
Member

dims commented Aug 4, 2017

/retest

2 similar comments
@dims
Copy link
Member

dims commented Aug 8, 2017

/retest

@cblecker
Copy link
Member

/retest

@dims
Copy link
Member

dims commented Aug 31, 2017

/test all

@dims
Copy link
Member

dims commented Sep 1, 2017

/test pull-kubernetes-e2e-kops-aws

@superbrothers
Copy link
Member Author

@dims Would you please rerun the following tests?

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-etcd3
/test pull-kubernetes-e2e-gce-bazel

@superbrothers superbrothers force-pushed the completions-config-rename-context branch from c0f16d5 to cd75007 Compare October 4, 2017 13:17
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2017
@dims
Copy link
Member

dims commented Oct 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2017
@superbrothers
Copy link
Member Author

@dims The failed test is not related to this PR. Please run /test pull-kubernetes-e2e-gce-bazel.

@superbrothers
Copy link
Member Author

/test pull-kubernetes-e2e-gce-bazel

@spiffxp
Copy link
Contributor

spiffxp commented Oct 24, 2017

/retest

@superbrothers
Copy link
Member Author

/test pull-kubernetes-e2e-gce-bazel

@superbrothers
Copy link
Member Author

/test pull-kubernetes-unit

@superbrothers
Copy link
Member Author

/test pull-kubernetes-e2e-gce-bazel

@superbrothers
Copy link
Member Author

/test pull-kubernetes-e2e-gce-bazel
/test pull-kubernetes-unit

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2017 •
edited
Loading

@superbrothers: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel cd75007 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@superbrothers
Copy link
Member Author

/test pull-kubernetes-e2e-gce-bazel

@superbrothers
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@cblecker
Copy link
Member

cblecker commented Nov 9, 2017

bump @smarterclayton for approval
/retest

@smarterclayton
Copy link
Contributor

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, smarterclayton, superbrothers

Associated issue requirement bypassed by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55268, 55282, 55419, 48340, 54829). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 81631ec into kubernetes:master Nov 10, 2017
@superbrothers superbrothers deleted the completions-config-rename-context branch November 11, 2017 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dims dims

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@superbrothers @k8s-ci-robot @spiffxp @dims @k8s-github-robot @cblecker @smarterclayton @fejta-bot