Skip to content

Conversation

@spowelljr
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14389) |
+----------------+----------+---------------------+
| minikube start | 56.6s    | 58.6s               |
| enable ingress | 28.9s    | 28.1s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 55.1s 57.7s 56.6s 57.5s 56.4s
Times for minikube (PR 14389) start: 58.2s 57.6s 58.8s 59.0s 59.3s

Times for minikube ingress: 29.1s 29.6s 26.1s 29.6s 30.1s
Times for minikube (PR 14389) ingress: 29.6s 30.1s 26.1s 29.6s 25.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14389) |
+-------------------+----------+---------------------+
| minikube start    | 28.0s    | 28.2s               |
| ⚠️  enable ingress | 23.3s    | 34.1s ⚠️             |
+-------------------+----------+---------------------+
Details

Times for minikube start: 28.7s 28.1s 27.8s 27.1s 28.3s
Times for minikube (PR 14389) start: 28.0s 28.6s 27.0s 28.5s 29.0s

Times for minikube ingress: 23.4s 22.9s 22.4s 24.9s 22.9s
Times for minikube (PR 14389) ingress: 21.4s 82.9s 22.9s 21.4s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14389) |
+----------------+----------+---------------------+
| minikube start | 33.0s    | 32.9s               |
| enable ingress | 29.4s    | 29.3s               |
+----------------+----------+---------------------+
Details

Times for minikube start: 35.0s 24.1s 35.6s 35.2s 35.3s
Times for minikube (PR 14389) start: 35.1s 24.7s 34.9s 35.2s 34.8s

Times for minikube ingress: 27.4s 27.9s 27.4s 26.9s 37.4s
Times for minikube (PR 14389) ingress: 37.0s 27.0s 27.5s 27.4s 27.4s

@spowelljr spowelljr merged commit f4b4128 into kubernetes:master Jun 22, 2022
@spowelljr spowelljr deleted the minikube1.26 branch June 22, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants