Skip to content

Conversation

@vtri950
Copy link

@vtri950 vtri950 commented Nov 27, 2025

Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility

Fixes #21967

Changes:

  • Upgrade BUILDROOT_BRANCH from 2025.02 to 2025.08.2
  • Remove custom gluster package (requires deprecated Python 2)
  • Remove custom podman package (now built-in to Buildroot 2025.08.2)

The newer Buildroot version includes updated package versions that are
compatible with modern GCC 13+ toolchains, eliminating build failures
on recent Linux distributions like Fedora 39+.

Tested on Fedora 43 with GCC 13.3.1.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vtri950. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vtri950
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nirs November 27, 2025 02:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nirs
Copy link
Contributor

nirs commented Nov 27, 2025

/ok-to-build-iso

Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtri950 thanks!

Makefile Outdated

INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1)
BUILDROOT_BRANCH ?= 2025.02
BUILDROOT_BRANCH ?= 2025.08.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use 2025.08?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025.08.02 is the latest stable patch release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://buildroot.org/download.html this version end of life is December 2025, so we have to update every month?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!
i have replaced it with the LTS version which contains the necessary fix.

@nirs
Copy link
Contributor

nirs commented Nov 28, 2025

failed iso build logs:
https://storage.cloud.google.com/minikube-builds/logs/21997/0cbf9da/iso_build.txt

Build failed with:

+ git remote add vtri950 git@github.com:vtri950/minikube.git
+ git fetch vtri950
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Build step 'Execute shell' marked build as failure

@medyagh any clue why the build tries to add this remote?

Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtri950 please rebase on master. The gluster package is already removed in master for long time. This may also fix the build iso job.

After rebase we see:

% git show --stat
commit 113d9e35755e9b5a7aea6537aded9ef3a56605bd (HEAD -> upgrade-buildroot-gcc13)
Author: Vidit Tripathi <viditt14@gmail.com>
Date:   Thu Nov 27 08:13:57 2025 +0530

    Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility

 Makefile                                             |  2 +-
 deploy/iso/minikube-iso/package/Config.in            |  1 -
 deploy/iso/minikube-iso/package/podman/Config.in     | 11 -----------
 deploy/iso/minikube-iso/package/podman/override.conf |  4 ----
 deploy/iso/minikube-iso/package/podman/podman.conf   |  1 -
 deploy/iso/minikube-iso/package/podman/podman.hash   |  7 -------
 deploy/iso/minikube-iso/package/podman/podman.mk     | 81 ---------------------------------------------------------------------------------
 7 files changed, 1 insertion(+), 106 deletions(-)

@vtri950
Copy link
Author

vtri950 commented Nov 30, 2025

failed iso build logs: https://storage.cloud.google.com/minikube-builds/logs/21997/0cbf9da/iso_build.txt

Build failed with:

+ git remote add vtri950 git@github.com:vtri950/minikube.git
+ git fetch vtri950
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Build step 'Execute shell' marked build as failure

@medyagh any clue why the build tries to add this remote?

the issue is here
https://github.com/kubernetes/minikube/blob/master/hack/jenkins/build_iso.sh#L88

@vtri950 vtri950 force-pushed the upgrade-buildroot-gcc13 branch from 0cbf9da to 8a09186 Compare November 30, 2025 04:19
@vtri950
Copy link
Author

vtri950 commented Nov 30, 2025

@vtri950 please rebase on master. The gluster package is already removed in master for long time. This may also fix the build iso job.

After rebase we see:

% git show --stat
commit 113d9e35755e9b5a7aea6537aded9ef3a56605bd (HEAD -> upgrade-buildroot-gcc13)
Author: Vidit Tripathi <viditt14@gmail.com>
Date:   Thu Nov 27 08:13:57 2025 +0530

    Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility

 Makefile                                             |  2 +-
 deploy/iso/minikube-iso/package/Config.in            |  1 -
 deploy/iso/minikube-iso/package/podman/Config.in     | 11 -----------
 deploy/iso/minikube-iso/package/podman/override.conf |  4 ----
 deploy/iso/minikube-iso/package/podman/podman.conf   |  1 -
 deploy/iso/minikube-iso/package/podman/podman.hash   |  7 -------
 deploy/iso/minikube-iso/package/podman/podman.mk     | 81 ---------------------------------------------------------------------------------
 7 files changed, 1 insertion(+), 106 deletions(-)

done

@nirs
Copy link
Contributor

nirs commented Nov 30, 2025

/ok-to-build-iso

@nirs
Copy link
Contributor

nirs commented Nov 30, 2025

/cc @afbjorklund

@vtri950 vtri950 force-pushed the upgrade-buildroot-gcc13 branch from 8a09186 to 6232705 Compare November 30, 2025 12:59
@vtri950 vtri950 changed the title Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility Upgrade Buildroot to 2025.02.8 LTS for GCC 13+ compatibility Nov 30, 2025
@nirs
Copy link
Contributor

nirs commented Nov 30, 2025

Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility

Fixes #21967

Changes:

  • Upgrade BUILDROOT_BRANCH from 2025.02 to 2025.08.2

Latest push change version to 2025.02.8

  • Remove custom gluster package (requires deprecated Python 2)

This was already in master for a while

  • Remove custom podman package (now built-in to Buildroot 2025.08.2)

The newer Buildroot version includes updated package versions that are compatible with modern GCC 13+ toolchains, eliminating build failures on recent Linux distributions like Fedora 39+.

Tested on Fedora 43 with GCC 13.3.1.

Did you test latest push with with Fedora 43?

Please update the PR message to reflect the actual change. If you are still testing it you can convert it to draft.

@nirs
Copy link
Contributor

nirs commented Nov 30, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @vtri950, building a new ISO failed for Commit 8a09186
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/21997/8a09186/iso_build.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minikube build fails

4 participants