-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Upgrade Buildroot to 2025.02.8 LTS for GCC 13+ compatibility #21997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @vtri950. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vtri950 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
/ok-to-build-iso |
nirs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtri950 thanks!
Makefile
Outdated
|
|
||
| INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1) | ||
| BUILDROOT_BRANCH ?= 2025.02 | ||
| BUILDROOT_BRANCH ?= 2025.08.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use 2025.08?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025.08.02 is the latest stable patch release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://buildroot.org/download.html this version end of life is December 2025, so we have to update every month?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
i have replaced it with the LTS version which contains the necessary fix.
|
failed iso build logs: Build failed with: @medyagh any clue why the build tries to add this remote? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtri950 please rebase on master. The gluster package is already removed in master for long time. This may also fix the build iso job.
After rebase we see:
% git show --stat
commit 113d9e35755e9b5a7aea6537aded9ef3a56605bd (HEAD -> upgrade-buildroot-gcc13)
Author: Vidit Tripathi <viditt14@gmail.com>
Date: Thu Nov 27 08:13:57 2025 +0530
Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility
Makefile | 2 +-
deploy/iso/minikube-iso/package/Config.in | 1 -
deploy/iso/minikube-iso/package/podman/Config.in | 11 -----------
deploy/iso/minikube-iso/package/podman/override.conf | 4 ----
deploy/iso/minikube-iso/package/podman/podman.conf | 1 -
deploy/iso/minikube-iso/package/podman/podman.hash | 7 -------
deploy/iso/minikube-iso/package/podman/podman.mk | 81 ---------------------------------------------------------------------------------
7 files changed, 1 insertion(+), 106 deletions(-)
the issue is here |
0cbf9da to
8a09186
Compare
done |
|
/ok-to-build-iso |
|
/cc @afbjorklund |
8a09186 to
6232705
Compare
Latest push change version to 2025.02.8
This was already in master for a while
Did you test latest push with with Fedora 43? Please update the PR message to reflect the actual change. If you are still testing it you can convert it to draft. |
|
/ok-to-build-iso |
|
Hi @vtri950, building a new ISO failed for Commit 8a09186 |
Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility
Fixes #21967
Changes:
The newer Buildroot version includes updated package versions that are
compatible with modern GCC 13+ toolchains, eliminating build failures
on recent Linux distributions like Fedora 39+.
Tested on Fedora 43 with GCC 13.3.1.