Skip to content

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Dec 26, 2025

based on good work by @ComradeProgrammer #20630

@medyagh medyagh requested a review from Copilot December 26, 2025 19:15
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps CRI-O from v1.29.1/v1.34 to v1.35 and crictl from v1.34.0 to v1.35.0 across the minikube kicbase and ISO images.

  • Updates CRI-O to v1.35.0 with corresponding commit hash and source tarball hash
  • Updates crictl to v1.35.0 for both x86_64 and aarch64 architectures with corresponding binary hashes
  • Adds two new prow integration test scripts to the automated crictl version update configuration

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
hack/update/crictl_version/crictl_version.go Adds two prow integration test scripts to the automated crictl version update configuration
hack/jenkins/linux_integration_tests_none.sh Updates crictl version from v1.34.0 to v1.35.0
deploy/kicbase/Dockerfile Updates CRI-O version from v1.34 to v1.35 and crictl from v1.34.0 to v1.35.0
deploy/iso/minikube-iso/package/crio-bin/crio-bin.mk Updates CRI-O version from v1.29.1 to v1.35.0 with new commit hash
deploy/iso/minikube-iso/package/crio-bin/crio-bin.hash Adds SHA256 hash for CRI-O v1.35.0 tarball
deploy/iso/minikube-iso/arch/x86_64/package/crictl-bin/crictl-bin.mk Updates crictl version from v1.34.0 to v1.35.0 for x86_64
deploy/iso/minikube-iso/arch/x86_64/package/crictl-bin/crictl-bin.hash Adds SHA256 hash for crictl v1.35.0 x86_64 binary
deploy/iso/minikube-iso/arch/aarch64/package/crictl-bin-aarch64/crictl-bin.mk Updates crictl version from v1.34.0 to v1.35.0 for aarch64
deploy/iso/minikube-iso/arch/aarch64/package/crictl-bin-aarch64/crictl-bin.hash Adds SHA256 hash for crictl v1.35.0 arm64 binary
.github/workflows/functional_test.yml Updates crictl version from v1.34.0 to v1.35.0 in functional tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@medyagh
Copy link
Member Author

medyagh commented Dec 26, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @medyagh, building a new ISO failed for Commit 504ba2a
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/22332/504ba2a/iso_build.txt

@medyagh
Copy link
Member Author

medyagh commented Dec 27, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @medyagh, building a new ISO failed for Commit 61c2387
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/22332/61c2387/iso_build.txt

@medyagh
Copy link
Member Author

medyagh commented Dec 27, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @medyagh, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 27, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 27, 2025
@medyagh
Copy link
Member Author

medyagh commented Dec 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 27, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22332 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 37.0s    │ 36.9s                  │
│ enable ingress │ 15.9s    │ 15.7s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 38.3s 36.8s 37.1s 36.7s 36.2s
Times for minikube (PR 22332) start: 36.7s 36.6s 38.2s 36.2s 36.7s

Times for minikube ingress: 16.3s 15.3s 15.8s 15.8s 16.3s
Times for minikube (PR 22332) ingress: 15.3s 15.3s 15.8s 16.3s 15.8s

docker driver with docker runtime

┌────────────────────┬──────────┬────────────────────────┐
│      COMMAND       │ MINIKUBE │ MINIKUBE  ( PR 22332 ) │
├────────────────────┼──────────┼────────────────────────┤
│ minikube start     │ 19.4s    │ 18.7s                  │
│ ⚠️  enable ingress │ 10.7s    │ 16.9s ⚠️               │
└────────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 17.7s 18.2s 21.0s 18.5s 21.4s
Times for minikube (PR 22332) start: 17.9s 18.0s 18.8s 19.3s 19.2s

Times for minikube ingress: 10.6s 10.6s 10.6s 10.6s 10.7s
Times for minikube (PR 22332) ingress: 10.6s 10.7s 41.7s 10.7s 10.7s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22332 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 19.2s    │ 18.2s                  │
│ enable ingress │ 23.0s    │ 22.8s                  │
└────────────────┴──────────┴────────────────────────┘
Details

Times for minikube start: 16.6s 19.8s 19.5s 20.4s 19.6s
Times for minikube (PR 22332) start: 20.0s 17.1s 16.5s 20.2s 17.2s

Times for minikube ingress: 23.2s 23.2s 23.1s 22.2s 23.2s
Times for minikube (PR 22332) ingress: 23.1s 22.1s 22.2s 23.2s 23.2s

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 27, 2025

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-vfkit-docker-macos-arm 56e1ce8 link false /test integration-vfkit-docker-macos-arm
integration-docker-crio-linux-x86 56e1ce8 link false /test integration-docker-crio-linux-x86
integration-docker-containerd-linux-x86 56e1ce8 link true /test integration-docker-containerd-linux-x86
integration-kvm-docker-linux-x86 56e1ce8 link true /test integration-kvm-docker-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd_arm64 (2 failed) TestForceSystemdFlag(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (2 failed) TestForceSystemdEnv(gopogh) 0.00% (chart)
Docker_Linux_docker_arm64 (2 failed) TestForceSystemdFlag(gopogh) 0.00% (chart)
Docker_Linux_docker_arm64 (2 failed) TestForceSystemdEnv(gopogh) 0.00% (chart)
KVM_Linux_crio (1 failed) TestFunctional/serial/ComponentHealth(gopogh) 0.00% (chart)
Docker_Windows (3 failed) TestForceSystemdFlag(gopogh) Unknown
Docker_Windows (3 failed) TestForceSystemdEnv(gopogh) Unknown
Docker_Windows (3 failed) TestErrorSpam/setup(gopogh) Unknown

Besides the following environments also have failed tests:

  • Docker_Linux_crio_arm64: 35 failed (gopogh)

  • Docker_Linux_crio: 26 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 240cecf into kubernetes:master Dec 28, 2025
39 of 54 checks passed
Copilot AI pushed a commit that referenced this pull request Dec 28, 2025
* ISO: upgrade crictl and crio to v1.35.0

* Kicbase: Update CRIO and CRICTL versions to v1.35

* auto updater: bump crictl version to v1.35.0 and extend version management to additional Prow integration scripts.

* chore: update crictl version to v1.35.0 in Prow integration scripts

* chore: remove empty line

* switch crio-bin to download pre-built static binaries instead of building from source.

* remove crio-shutdown service link (depricated)

* update crio.service to match upstream with minikube flavor

* build: Adjust crio and pinns binary installation source paths.

* Updating ISO to v1.37.0-1766811082-22332

---------

Co-authored-by: minikube-bot <minikube-bot@google.com>
star3am pushed a commit to star3am/minikube that referenced this pull request Jan 2, 2026
* ISO: upgrade crictl and crio to v1.35.0

* Kicbase: Update CRIO and CRICTL versions to v1.35

* auto updater: bump crictl version to v1.35.0 and extend version management to additional Prow integration scripts.

* chore: update crictl version to v1.35.0 in Prow integration scripts

* chore: remove empty line

* switch crio-bin to download pre-built static binaries instead of building from source.

* remove crio-shutdown service link (depricated)

* update crio.service to match upstream with minikube flavor

* build: Adjust crio and pinns binary installation source paths.

* Updating ISO to v1.37.0-1766811082-22332

---------

Co-authored-by: minikube-bot <minikube-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants