-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Kicbase/iso: bump crio to v1.35 #22332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ement to additional Prow integration scripts.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps CRI-O from v1.29.1/v1.34 to v1.35 and crictl from v1.34.0 to v1.35.0 across the minikube kicbase and ISO images.
- Updates CRI-O to v1.35.0 with corresponding commit hash and source tarball hash
- Updates crictl to v1.35.0 for both x86_64 and aarch64 architectures with corresponding binary hashes
- Adds two new prow integration test scripts to the automated crictl version update configuration
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hack/update/crictl_version/crictl_version.go | Adds two prow integration test scripts to the automated crictl version update configuration |
| hack/jenkins/linux_integration_tests_none.sh | Updates crictl version from v1.34.0 to v1.35.0 |
| deploy/kicbase/Dockerfile | Updates CRI-O version from v1.34 to v1.35 and crictl from v1.34.0 to v1.35.0 |
| deploy/iso/minikube-iso/package/crio-bin/crio-bin.mk | Updates CRI-O version from v1.29.1 to v1.35.0 with new commit hash |
| deploy/iso/minikube-iso/package/crio-bin/crio-bin.hash | Adds SHA256 hash for CRI-O v1.35.0 tarball |
| deploy/iso/minikube-iso/arch/x86_64/package/crictl-bin/crictl-bin.mk | Updates crictl version from v1.34.0 to v1.35.0 for x86_64 |
| deploy/iso/minikube-iso/arch/x86_64/package/crictl-bin/crictl-bin.hash | Adds SHA256 hash for crictl v1.35.0 x86_64 binary |
| deploy/iso/minikube-iso/arch/aarch64/package/crictl-bin-aarch64/crictl-bin.mk | Updates crictl version from v1.34.0 to v1.35.0 for aarch64 |
| deploy/iso/minikube-iso/arch/aarch64/package/crictl-bin-aarch64/crictl-bin.hash | Adds SHA256 hash for crictl v1.35.0 arm64 binary |
| .github/workflows/functional_test.yml | Updates crictl version from v1.34.0 to v1.35.0 in functional tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/ok-to-build-iso |
|
Hi @medyagh, building a new ISO failed for Commit 504ba2a |
|
/ok-to-build-iso |
|
Hi @medyagh, building a new ISO failed for Commit 61c2387 |
|
/ok-to-build-iso |
|
Hi @medyagh, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
/ok-to-test |
|
kvm2 driver with docker runtime DetailsTimes for minikube start: 38.3s 36.8s 37.1s 36.7s 36.2s Times for minikube ingress: 16.3s 15.3s 15.8s 15.8s 16.3s docker driver with docker runtime DetailsTimes for minikube start: 17.7s 18.2s 21.0s 18.5s 21.4s Times for minikube ingress: 10.6s 10.6s 10.6s 10.6s 10.7s docker driver with containerd runtime DetailsTimes for minikube start: 16.6s 19.8s 19.5s 20.4s 19.6s Times for minikube ingress: 23.2s 23.2s 23.1s 22.2s 23.2s |
|
@medyagh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests: To see the flake rates of all tests by environment, click here. |
* ISO: upgrade crictl and crio to v1.35.0 * Kicbase: Update CRIO and CRICTL versions to v1.35 * auto updater: bump crictl version to v1.35.0 and extend version management to additional Prow integration scripts. * chore: update crictl version to v1.35.0 in Prow integration scripts * chore: remove empty line * switch crio-bin to download pre-built static binaries instead of building from source. * remove crio-shutdown service link (depricated) * update crio.service to match upstream with minikube flavor * build: Adjust crio and pinns binary installation source paths. * Updating ISO to v1.37.0-1766811082-22332 --------- Co-authored-by: minikube-bot <minikube-bot@google.com>
* ISO: upgrade crictl and crio to v1.35.0 * Kicbase: Update CRIO and CRICTL versions to v1.35 * auto updater: bump crictl version to v1.35.0 and extend version management to additional Prow integration scripts. * chore: update crictl version to v1.35.0 in Prow integration scripts * chore: remove empty line * switch crio-bin to download pre-built static binaries instead of building from source. * remove crio-shutdown service link (depricated) * update crio.service to match upstream with minikube flavor * build: Adjust crio and pinns binary installation source paths. * Updating ISO to v1.37.0-1766811082-22332 --------- Co-authored-by: minikube-bot <minikube-bot@google.com>
based on good work by @ComradeProgrammer #20630