Skip to content

build: Don't install golang-go but use host-go instead #22355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
medyagh merged 1 commit into from
Dec 29, 2025
Merged

build: Don't install golang-go but use host-go instead #22355

medyagh merged 1 commit into from
Dec 29, 2025
+4 −2

Conversation

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Dec 29, 2025 •
edited
Loading

Use the go compiler from buildroot for building packages, instead of installing a go compiler in the builder image.

Make sure to build the host-go package and set up GOCACHE, before minikube packages have been fixed to use golang.mk

Now that there host-go-bin, it won't even need bootstrapping (there is still host-go-src, should it ever be needed)

Closes #22228

@afbjorklund
Don't install golang-go but use host-go instead
3d22c16 
Use the go compiler from buildroot for building packages,
instead of installing a go compiler in the builder image.

Make sure to build the host-go package and set up GOCACHE,
before minikube packages have been fixed to use golang.mk
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 29, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2025

@afbjorklund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-docker-containerd-linux-arm 3d22c16 link false /test integration-docker-containerd-linux-arm
integration-docker-containerd-linux-x86 3d22c16 link true /test integration-docker-containerd-linux-x86
integration-docker-docker-linux-arm 3d22c16 link true /test integration-docker-docker-linux-arm
integration-kvm-crio-linux-x86 3d22c16 link false /test integration-kvm-crio-linux-x86
integration-docker-crio-linux-x86 3d22c16 link false /test integration-docker-crio-linux-x86

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh medyagh changed the title Don't install golang-go but use host-go instead build: Don't install golang-go but use host-go instead Dec 29, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2025
@medyagh
Copy link
Member

medyagh commented Dec 29, 2025

/lgtm

@medyagh medyagh merged commit 210b159 into kubernetes:master Dec 29, 2025
32 of 40 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI pushed a commit that referenced this pull request Dec 29, 2025
@afbjorklund
Don't install golang-go but use host-go instead (#22355)
22f5f28 
Use the go compiler from buildroot for building packages,
instead of installing a go compiler in the builder image.

Make sure to build the host-go package and set up GOCACHE,
before minikube packages have been fixed to use golang.mk
star3am pushed a commit to star3am/minikube that referenced this pull request Jan 2, 2026
@afbjorklund @star3am
Don't install golang-go but use host-go instead (kubernetes#22355)
a7ddcc7 
Use the go compiler from buildroot for building packages,
instead of installing a go compiler in the builder image.

Make sure to build the host-go package and set up GOCACHE,
before minikube packages have been fixed to use golang.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

Assignees

@medyagh medyagh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't install golang-go compiler in the builder image

3 participants

@afbjorklund @k8s-ci-robot @medyagh