Skip to content

sig-pm: Add project-board-maintainers team#496

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
justaugustus:pm
Feb 19, 2019
Merged

sig-pm: Add project-board-maintainers team#496
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
justaugustus:pm

Conversation

@justaugustus
Copy link
Copy Markdown
Member

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @calebamiles @idvoretskyi @jdumars

@k8s-ci-robot k8s-ci-robot added sig/pm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2019
@idvoretskyi
Copy link
Copy Markdown
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2019
Copy link
Copy Markdown
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This was discussed at the latest Steering committee meeting.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 16, 2019
@cblecker
Copy link
Copy Markdown
Member

What’s the intent here as far as permissions?

@justaugustus
Copy link
Copy Markdown
Member Author

@cblecker -- I've added an issue to discuss project grooming here: kubernetes/community#3267

Basically, groups that wanted their backlogs groomed would add project-managers to their board with write access. Ideally, I'd love if that would happen automatically for org-level boards, but I'm not sure if that's possible in GitHub.

@cblecker
Copy link
Copy Markdown
Member

two nit picky things (aka naming is hard):

  • "project-managers" has a more generic implication, rather than "a team of people who are being given permissions to board". maybe something like "sig-pm-board-maintainers" would be more explicit as to what the team is actually doing
  • The description kind of implies "this group must be given permissions to boards" as opposed to "this is a team of people who can sigs can subscribe to, to help them with maintaining project boards". The latter is a bit wordy, but again, maybe there is a way to be more clear.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@cblecker cblecker changed the title sig-pm: Add project-managers team sig-pm: Add project-board-maintainers team Feb 19, 2019
@cblecker
Copy link
Copy Markdown
Member

/lgtm
/approve

Looks great, @justaugustus!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Copy Markdown
Member Author

@cblecker -- thanks for the tips! Updated team name to project-board-maintainers and updated description.

@justaugustus
Copy link
Copy Markdown
Member Author

/hold cancel
(Ihor's hold was around the communication aspect of it, but this has now been opened for discussion in kubernetes/community#3267)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2af53f0 into kubernetes:master Feb 19, 2019
@idvoretskyi
Copy link
Copy Markdown
Member

/hold cancel
(Ihor's hold was around the communication aspect of it, but this has now been opened for discussion in kubernetes/community#3267)

+1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants