Skip to content

SIG Scheduling: Leadership Change #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dom4ha wants to merge 0 commits into from
Closed

SIG Scheduling: Leadership Change #5550

dom4ha wants to merge 0 commits into from

Conversation

@dom4ha
Copy link
Member

@dom4ha dom4ha commented Apr 22, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Apr 22, 2025
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2025
dom4ha
dom4ha commented Apr 22, 2025
View reviewed changes
Copy link
Member Author

@dom4ha dom4ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I should put @macsko as Chair to those files as well. I haven't found any specific guidelines.

cc @sanposhiho, @macsko, @alculquicondor, @Huang-Wei, @ahg-g

sanposhiho
sanposhiho reviewed Apr 22, 2025
View reviewed changes
config/kubernetes/sig-scheduling/teams.yaml
- macsko
- sanposhiho
privacy: closed
sig-scheduling-leads:
Copy link
Member

@sanposhiho sanposhiho Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can. In daily life, it'd be more convenient for us if we could include @macsko in this sig-scheduling-leads github team, at least.

Copy link
Member

@alculquicondor alculquicondor Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leads includes Chairs and TLs

@dom4ha
Copy link
Member Author

dom4ha commented Apr 22, 2025

Not sure if I should put Maciej Skoczeń as Chair to those files as well. I haven't found any specific guidelines.

Looking at https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md, milestone management is also Chair responsibility, so added Maciek to all places except of enhancement OWNERS.

@alculquicondor
Copy link
Member

alculquicondor commented Apr 22, 2025

/approve

@dom4ha dom4ha mentioned this pull request Apr 24, 2025
Closed
17 tasks
@dom4ha
Copy link
Member Author

dom4ha commented Apr 24, 2025

Looking at https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md, milestone management is also Chair responsibility, so added Maciek to all places except of enhancement OWNERS.

Added Maciek to enahancement OWNERS as well based on kubernetes/enhancements#5256 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 28, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dom4ha
Copy link
Member Author

dom4ha commented May 5, 2025

Unfortunately I messed up something in my repo, so I need to send a new PR and close this one :(

@dom4ha dom4ha closed this May 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alculquicondor, dom4ha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2025
@dom4ha dom4ha mentioned this pull request May 5, 2025
Merged
@dom4ha
Copy link
Member Author

dom4ha commented May 5, 2025

The new PR is in #5571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

2 more reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@sanposhiho sanposhiho sanposhiho left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dom4ha @alculquicondor @k8s-ci-robot @sanposhiho