-
Couldn't load subscription status.
- Fork 527
gcb: Move KMS keys to k8s-releng-prod GCP project #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
|
@justaugustus: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Ready for review: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
for more eyes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What type of PR is this?
/kind cleanup feature
What this PR does / why we need it:
Now that KMS usage has been documented in kubernetes/sig-release#1016, we should cutover our GCB configs to use KMS assets in the
k8s-releng-prodGCP project.Signed-off-by: Stephen Augustus saugustus@vmware.com
ref: #911, kubernetes/k8s.io#641
Special notes for your reviewer:
KMS decrypter access granted to the
kubernetes-release-testGCB service account:$ gcloud kms keys add-iam-policy-binding \ encrypt-0 --location=global --keyring=release \ --member=serviceAccount:648026197307@cloudbuild.gserviceaccount.com \ --role=roles/cloudkms.cryptoKeyDecrypterUpdated IAM policy for key [encrypt-0]. bindings: - members: - serviceAccount:117157742389@cloudbuild.gserviceaccount.com - serviceAccount:615281671549@cloudbuild.gserviceaccount.com - serviceAccount:648026197307@cloudbuild.gserviceaccount.com role: roles/cloudkms.cryptoKeyDecrypter etag: BwWgakJY2PQ= version: 1Does this PR introduce a user-facing change?: