Skip to content

Fix image building post-submits: first pass #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2021
Merged

Fix image building post-submits: first pass #2001

merged 3 commits into from
Apr 15, 2021

Conversation

@justaugustus
Copy link
Member

@justaugustus justaugustus commented Apr 15, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup failing-test regression

What this PR does / why we need it:

The following post-submit jobs are failing:

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-k8s-ci-builder/1382488810838822912:

denied: Token exchange failed for project 'k8s-staging-build-image'. Caller does not have permission 'storage.buckets.get'. To configure permissions, follow instructions at: https://cloud.google.com/container-registry/docs/access-control
make: *** [Makefile:61: push] Error 1
ERROR: (gcloud.builds.submit) build a9a85c0c-1f57-48dd-95f3-04b02c69c0b0 completed with status "FAILURE"
ERROR
ERROR: build step 0 "gcr.io/k8s-testimages/gcb-docker-gcloud:v20201130-750d12f" failed: step exited with non-zero status: 2

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-k8s-cloud-builder/1380321161795080192:

ERROR: (gcloud.builds.submit) build 1b81b04c-408d-41a6-a1b9-e8dc5ffe9014 completed with status "FAILURE"
Finished Step #1 - "test"
ERROR
ERROR: failed to find one or more images after execution of build steps: ["gcr.io/k8s-staging-releng/k8s-cloud-builder:v20210409-v0.8.0-14-g0539f9b7-cross1.16" "gcr.io/k8s-staging-releng/k8s-cloud-builder:latest-cross1.16" "gcr.io/k8s-staging-releng/k8s-cloud-builder:v1.16.1-1"]

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-kubepkg/1382488810868183040:

Finished Step #1
ERROR
ERROR: failed to find one or more images after execution of build steps: ["gcr.io/k8s-staging-releng/kubepkg:v20210415-v0.8.0-36-g9d8604e1" "gcr.io/k8s-staging-releng/kubepkg:latest" "gcr.io/k8s-staging-releng/kubepkg-rpm:v20210415-v0.8.0-36-g9d8604e1" "gcr.io/k8s-staging-releng/kubepkg-rpm:latest"]

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-releng-ci/1380321161841217536:

Finished Step #1
ERROR
ERROR: failed to find one or more images after execution of build steps: ["gcr.io/k8s-staging-releng/releng-ci:v20210409-v0.8.0-14-g0539f9b7" "gcr.io/k8s-staging-releng/releng-ci:v0.5.0" "gcr.io/k8s-staging-releng/releng-ci:latest"]
ERROR: (gcloud.builds.submit) build e8f891da-cb23-4a0a-af28-ff9061127aa5 completed with status "FAILURE"

Let's fix them!

Signed-off-by: Stephen Augustus foo@auggie.dev

Which issue(s) this PR fixes:

Special notes for your reviewer:

xref staging registry corrections: kubernetes/test-infra#21821

Does this PR introduce a user-facing change?

dependencies: Add Golang entries for previous release branches

@justaugustus
[DROP] Temp files to trigger image building presubmits
e06a0db 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
@justaugustus
Copy link
Member Author

justaugustus commented Apr 15, 2021

(First commit is meant to ensure the presubmits are failing properly.)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
@justaugustus
dependencies: Add Golang entries for previous release branches
49ddfab 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
k8s-ci-builder: Retrigger builds with correct Golang versions
8756b6f 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus changed the title [WIP] Fix image building post-submits Fix image building post-submits: first pass Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2021
@justaugustus
Copy link
Member Author

justaugustus commented Apr 15, 2021

/assign @hasheddan @puerco @cpanato
Let's get this in as a first-pass so I can monitor the post-submits and determine next steps.

@justaugustus
Copy link
Member Author

justaugustus commented Apr 15, 2021

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 15, 2021
hasheddan
hasheddan approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hasheddan,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented Apr 15, 2021

/lgtm

@justaugustus
Copy link
Member Author

justaugustus commented Apr 15, 2021

(Noting as well for the record that previous runs of image building presubmits on this PR did not fail as expected, so something is up.)

@justaugustus
Copy link
Member Author

justaugustus commented Apr 15, 2021

k8s-ci-builder is going to fail because of some Go-isms that I can fix in a follow-up.

/skip

@justaugustus
Copy link
Member Author

justaugustus commented Apr 15, 2021

/override pull-release-image-k8s-ci-builder

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 15, 2021

@justaugustus: Overrode contexts on behalf of justaugustus: pull-release-image-k8s-ci-builder

In response to this:

/override pull-release-image-k8s-ci-builder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit c1b2420 into kubernetes:master Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 15, 2021
@justaugustus justaugustus mentioned this pull request Apr 15, 2021
Merged
@justaugustus
Copy link
Member Author

justaugustus commented Apr 16, 2021

This fixed the k8s-cloud-builder job: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-k8s-cloud-builder/1382830189263720448

kubernetes/test-infra#21821 should fix a few more.

@justaugustus justaugustus mentioned this pull request Apr 16, 2021
Merged
@puerco puerco mentioned this pull request Apr 16, 2021
Merged
@justaugustus justaugustus mentioned this pull request Apr 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@xmudrii xmudrii Awaiting requested review from xmudrii

1 more reviewer

@hasheddan hasheddan hasheddan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@puerco puerco

@cpanato cpanato

@hasheddan hasheddan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

5 participants

@justaugustus @k8s-ci-robot @puerco @hasheddan @cpanato