Skip to content

Conversation

@jihoon-seo
Copy link
Member

@jihoon-seo jihoon-seo commented Apr 26, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Having headers in krel release-notes output caused the end result of k/k changelog to have duplicated headers. We had to fix this in 1.20 and again in 1.21 after the release.

'Source Code' heading is missing in krel-generated files.
Please refer to https://github.com/kubernetes/kubernetes/pull/101299/files .

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

pkg/changelog: Add missing "Source Code" heading, fix upper-case consistency in headings, and remove duplicates

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 26, 2021
@jihoon-seo
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@jihoon-seo jihoon-seo force-pushed the 210422_Fix_generating_duplicates_and_omitting_heading branch from 1826e59 to 42d35a5 Compare April 26, 2021 01:53
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2021
@jihoon-seo
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@jihoon-seo
Copy link
Member Author

CC: @wilsonehusin , PTAL!

@wilsonehusin
Copy link
Contributor

this is awesome, thanks for contributing!

I think this warrants a release note? something like:

pkg/changelog: Add missing "downloads" heading and fix upper-case consistency in headings

otherwise, code is 👍🏼

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@jihoon-seo
Copy link
Member Author

@wilsonehusin Thank you for your suggestion.

I propose another suggestion which is almost the same:

pkg/changelog: Add missing "Source Code" heading, fix upper-case consistency in headings, and remove duplicates

Would it be okay to put this release note into the "Does this PR introduce a user-facing change?" field of this PR? 😊

@wilsonehusin
Copy link
Contributor

ah good catch -- yes that looks better!

Would it be okay to put this release note into the "Does this PR introduce a user-facing change?" field of this PR? 😊

yep that's the right place to do it

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 26, 2021
@jihoon-seo
Copy link
Member Author

@wilsonehusin Done putting. PTAL. Thank you! 😊

@wilsonehusin
Copy link
Contributor

let's wait for people with approval powers, i don't think i have any here 😆

/priority backlog
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit b38e4e5 into kubernetes:master Apr 30, 2021
@jihoon-seo jihoon-seo deleted the 210422_Fix_generating_duplicates_and_omitting_heading branch April 30, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing 'Source Code' heading in krel output

4 participants