-
Notifications
You must be signed in to change notification settings - Fork 526
Fix generating duplicates and omitting heading #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generating duplicates and omitting heading #2020
Conversation
|
/hold |
1826e59 to
42d35a5
Compare
|
/unhold |
|
CC: @wilsonehusin , PTAL! |
|
this is awesome, thanks for contributing! I think this warrants a release note? something like: otherwise, code is 👍🏼 /lgtm |
|
@wilsonehusin Thank you for your suggestion. I propose another suggestion which is almost the same: Would it be okay to put this release note into the "Does this PR introduce a user-facing change?" field of this PR? 😊 |
|
ah good catch -- yes that looks better!
yep that's the right place to do it |
|
@wilsonehusin Done putting. PTAL. Thank you! 😊 |
|
let's wait for people with approval powers, i don't think i have any here 😆 /priority backlog |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jihoon-seo, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
krel release-notesoutput #1993: "Remove duplicates inkrel release-notesoutput")kreloutput #2012: "Add missing 'Source Code' heading inkreloutput")Which issue(s) this PR fixes:
krel release-notesoutput #1993 ("Remove duplicates inkrel release-notesoutput")kreloutput #2012 ("Add missing 'Source Code' heading inkreloutput")Special notes for your reviewer:
Does this PR introduce a user-facing change?