Drop krel cve write command #2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two functions to the CVE package: `cve.ValidateID` checks CVE ids externally Client.EntryExists checks if we already have an entry for a specific CVE
This command drops the previous cve write command and modifies `krel cve edit` to open a new CVE if it does not exist in the bucket yet.
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
Member
Author
|
Found a bug in the gcs package which needs to go in before this change can be used to edit new CVEs: #2028 /milestone v1.22 |
k8s-ci-robot
added
the
priority/important-soon
saschagrunert
approved these changes
May 3, 2021
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Iterating on the
krel cvecommand, this command modifies it to remove thewritesubcommand to simplify the interface.Previously, we used
krel writeto create a new CVE entry, andkrel editto modify an existing entry.This PR combines both into krel edit, which will present the new CVE template if the entry does not exist yet or pull a CVE entry if we already have data for it.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Depends on #2028
Does this PR introduce a user-facing change?