pkg/cip: Revert os/io go1.16 changes #2097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigs.k8s.io/k8s-container-image-promoter is currently stuck on go1.15 due to a variety of bazel dependency updates that are not straightforward to untangle. Due to the incompatibility of the updated os/io packages with go1.15, we're no longer able to update k/release in k-sigs/cip. This commit reverts the go1.16 os/io usage to the go1.15-compatible ioutil methods. Signed-off-by: Stephen Augustus <foo@auggie.dev>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/artifacts
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
(Testing here: kubernetes-sigs/promo-tools#299) |
Member
Author
|
Still getting test errors in kubernetes-sigs/promo-tools#299, but they're unrelated and also visible in kubernetes-sigs/promo-tools#285 and kubernetes-sigs/promo-tools#291. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup regression
What this PR does / why we need it:
sigs.k8s.io/k8s-container-image-promoter is currently stuck on go1.15
due to a variety of bazel dependency updates that are not straightforward
to untangle.
Due to the incompatibility of the updated os/io packages with go1.15, we're
no longer able to update k/release in k-sigs/cip.
This commit reverts the go1.16 os/io usage to the go1.15-compatible ioutil
methods.
Signed-off-by: Stephen Augustus foo@auggie.dev
Which issue(s) this PR fixes:
Special notes for your reviewer:
/hold going to quickly check if this is now importable from k-sigs/cip using my fork
Does this PR introduce a user-facing change?