Skip to content

Conversation

@justaugustus
Copy link
Member

@justaugustus justaugustus commented May 31, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Companion PR for kubernetes-sigs/promo-tools#291.
ref: kubernetes-sigs/promo-tools#266

Signed-off-by: Stephen Augustus foo@auggie.dev

Which issue(s) this PR fixes:

Special notes for your reviewer:

I wrestled with creating a v3 module for CIP, but bazel had issues with interpreting the new module dependencies.
Instead, I've cut a v1.337.0 tag to allow the "new" repo content to be imported.

Does this PR introduce a user-facing change?

pkg/cip: Migrate packages back to k-sigs/cip

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 31, 2021
@k8s-ci-robot k8s-ci-robot requested review from hasheddan and puerco May 31, 2021 11:04
@justaugustus
Copy link
Member Author

/assign @saschagrunert @xmudrii
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8c7fd7 into kubernetes:master May 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants