Skip to content

cherry-pick #60 and #61 to release-1.12 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

cherry-pick #60 and #61 to release-1.12 #62

merged 2 commits into from
Oct 23, 2025
+94 −3

Conversation

@neolit123
Copy link
Member

kannon92 and others added 2 commits October 23, 2025 17:26
@kannon92 @neolit123
fix typo for cgroup removal kep
2d593d2
@neolit123
cgroup_validator: add a KubeletVersion field
8caa0bb 
Add a KubeletVersion to the validator struct. This allows
to parse the version and make a decision to show a warning
or an error. Add a new function isCgroupsV1DisabledInKubelet
that does that and include unit tests for it.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
@neolit123
Copy link
Member Author

adding self - lgtm to push a new 1.12.1 release and continue work on the k/k PR.

@neolit123 neolit123 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0656506 into kubernetes:release-1.12 Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlory carlory Awaiting requested review from carlory

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neolit123 @k8s-ci-robot @kannon92