cgroup_validator: add a KubeletVersion field #61
Merged
+94
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolit123
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
neolit123
force-pushed
the
1.35-make-cgroup-validator-consider-kubelet-version
branch
from
35d9fab to
f17cbb5
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
neolit123
force-pushed
the
1.35-make-cgroup-validator-consider-kubelet-version
branch
2 times, most recently
from
1597bf8 to
7343fc1
Compare
Closed
k8s-ci-robot
added
the
lgtm
Add a KubeletVersion to the validator struct. This allows to parse the version and make a decision to show a warning or an error. Add a new function isCgroupsV1DisabledInKubelet that does that and include unit tests for it.
neolit123
force-pushed
the
1.35-make-cgroup-validator-consider-kubelet-version
branch
from
7343fc1 to
4a53f46
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58
once this merges we need to update kubeadm to pass set the new KubelerVersion field.