Skip to content

Conversation

@cici37
Copy link
Contributor

@cici37 cici37 commented Mar 6, 2024

ValidatingAdmissionPolicy is graduated to GA in 1.30 and the feature gate is turned on by default, hence we will disable the test from alpha/beta. The same e2e tests are enabled in presubmit job through kubernetes/kubernetes#123774.
Thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@cici37
Copy link
Contributor Author

cici37 commented Mar 6, 2024

/hold
til kubernetes/kubernetes#123774 merged first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 6, 2024
@cici37
Copy link
Contributor Author

cici37 commented Mar 7, 2024

/unhold
/assign @cheftako @andrewsykim
for approval when you have time :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2024
@cici37
Copy link
Contributor Author

cici37 commented Mar 14, 2024

/assign @jiahuif for review. Thanks!

@jiahuif
Copy link
Contributor

jiahuif commented Mar 14, 2024

/lgtm
/assign @cheftako @andrewsykim

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 14, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@cici37
Copy link
Contributor Author

cici37 commented Mar 28, 2024

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
@cheftako
Copy link
Member

cheftako commented May 1, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, cici37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2452683 into kubernetes:master May 1, 2024
@k8s-ci-robot
Copy link
Contributor

@cici37: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key periodic-e2e.yaml using file config/jobs/kubernetes/sig-cloud-provider/periodic-e2e.yaml
Details

In response to this:

ValidatingAdmissionPolicy is graduated to GA in 1.30 and the feature gate is turned on by default, hence we will disable the test from alpha/beta. The same e2e tests are enabled in presubmit job through kubernetes/kubernetes#123774.
Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cici37 cici37 deleted the vapGA branch May 1, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants