-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix a bug in gcb-docker-gcloud image #36071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Verified the fix locally: |
BenTheElder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| gcloud config set metrics/environment github_docker_image && \ | ||
| gcloud components install alpha beta gke-gcloud-auth-plugin gsutil && \ | ||
| gcloud --version && \ | ||
| gcloud auth configure-docker gcr.io,us-central1-docker.pkg.dev && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someday we're going to have fun tracking down the hardcoded regions but that's NOT new to this PR :-)
thanks!
/cc @BenTheElder