Add set type for net.IP

[andrewsykim]

As discussed in kubernetes/kubernetes#85617 (comment), it would be generically useful to have a set type for net.IP.

/assign @danwinship @thockin

[danwinship]

/lgtm
in terms of correctness and consistency with IPNetSet, though it's annoying that IPNetSet (and now IPSet) is inconsistent with k8s.io/apimachinery/pkg/util/set. eg, ParseIPNets() rather than NewIPNet() and StringSlice() rather than UnsortedList() and no Union()/Intersection()/etc

[andrewsykim]

though it's annoying that IPNetSet (and now IPSet) is inconsistent with k8s.io/apimachinery/pkg/util/set. eg, ParseIPNets() rather than NewIPNet() and StringSlice() rather than UnsortedList() and no Union()/Intersection()/etc

💯 agree with this. I can look into this in a follow-up PR but it's quite a bit of work because we have to revendor it back to kubernetes/kubernetes and updating existing callers of the old functions. .

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, danwinship, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment