Skip to content

Conversation

@crassirostris
Copy link

@crassirostris crassirostris commented Jan 3, 2017

This is a replacement for https://github.com/kubernetes/contrib/tree/master/logging/fluentd-sidecar-gcp and https://github.com/kubernetes/contrib/tree/master/logging/fluentd-sidecar-es, describing general sidecar approach, including things not covered by docs above:

  • Configuring sidecar logging agent using ConfigMaps
  • Alternative use for sidecar, where it streams logs to stdout/stderr rather than has a logging agent inside

Related to #548

CC @piosz @devin-donnelly @steveperry-53


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 3, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 3, 2017
@devin-donnelly
Copy link
Contributor

@crassirostris , since release-1.5 has merged into Master, all changes should now target the Master branch. Please retarget this PR to master.

@janetkuo
Copy link
Member

janetkuo commented Jan 3, 2017

Thanks for this. I'm closing this PR just because GitHub doesn't allow updating target branch in a PR. Feel free to open a new one targeting master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants