Skip to content

fix race condition in app form #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mms-gianni merged 1 commit into from
Nov 4, 2024
Merged

fix race condition in app form #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions client/src/components/apps/form.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1646,15 +1646,12 @@ export default defineComponent({
},
},
mounted() {
this.loadPipeline();
this.loadPipelineAndApp();
this.loadStorageClasses();
this.loadPodsizeList();
this.loadBuildpacks();
this.loadClusterIssuers();
this.getDomains();
if (this.app != 'new') {
this.loadApp(); // this may lead into a race condition with the buildpacks loaded in loadPipeline
}

if (this.$route.query.template && this.$route.query.catalogId) {
const catalogId = this.$route.query.catalogId as string;
Expand Down Expand Up @@ -1762,7 +1759,7 @@ export default defineComponent({
changeName(name: string) {
this.ingress.hosts[0].host = name+"."+this.pipelineData.domain;
},
loadPipeline() {
loadPipelineAndApp() {
axios.get('/api/pipelines/'+this.pipeline).then(response => {
this.pipelineData = response.data;

Expand Down Expand Up @@ -1803,6 +1800,11 @@ export default defineComponent({
this.buildpack.run.readOnlyAppStorage = true;
}

if (this.app != 'new') {
this.loadApp();
}


});
},
loadStorageClasses() {
Expand Down