Conversation
|
Summary:
|
matthyx
force-pushed
the
include
branch
4 times, most recently
from
3da1cc1 to
4610773
Compare
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
Bezbran
previously approved these changes
Jul 15, 2024
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Bezbran
approved these changes
Jul 15, 2024
|
Summary:
|
entlein
pushed a commit
to k8sstormcenter/node-agent
that referenced
this pull request
May 27, 2026
Removing the Patterns scan when cp.Opens.All==true (PR kubescape#811 original diff) regressed projectField()'s pass-through behavior: ap.was_path_opened_with_suffix/_prefix returned false for dynamic entries kept only in cp.Opens.Patterns when the rule omitted profileDataRequired.opens. Restores a narrower Patterns scan that, in All-mode, considers each pattern's CONCRETE SUFFIX/PREFIX (text up to the first '*' or '⋯') rather than the full pattern body. This keeps the spoof-resistance intent matthyx noted (rejecting raw HasPrefix/HasSuffix over attacker-influenced pattern strings) while restoring matches for the dynamic entries the All-mode contract is supposed to cover. The two segment-iteration sites that classify wildcard tokens now match the bare "*" literal directly rather than depending on dynamicpathdetector.WildcardIdentifier (added in storage kubescape#323, not yet in NA's pinned storage v0.0.258). DynamicIdentifier reference stays — it's been in storage since long before v0.0.258. Resolves matthyx review on open.go:125 (2026-05-19).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.