fix: remove job-level permissions from benchmark workflow#778
Conversation
The benchmark job declared pull-requests: write which conflicts with the release pipeline (incluster-comp-pr-merged.yaml) that only grants pull-requests: read, causing a startup_failure. Remove the job-level permissions block so the workflow inherits from the caller. The PR comment step already guards with if: github.event_name == 'pull_request' and now has continue-on-error for extra safety. Signed-off-by: Ben <ben@armosec.io>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 2 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the reusable benchmark workflow’s permissions so it can be invoked from the release pipeline without failing permission validation, while making PR commenting best-effort.
Changes:
- Removed the benchmark job’s job-level
permissionsblock so the workflow inherits the caller’s permissions (avoidsstartup_failurewhen called by workflows granting onlypull-requests: read). - Marked the “Comment on PR” step as
continue-on-error: trueto prevent permission-related failures from failing the job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The benchmark job declared
pull-requests: writewhich conflicts with the release pipeline (incluster-comp-pr-merged.yaml) that only grantspull-requests: read, causing astartup_failureon merge.Removes the job-level permissions block so the workflow inherits caller permissions. The PR comment step already guards with
if: github.event_name == 'pull_request'and now hascontinue-on-errorfor safety.Fixes: https://github.com/kubescape/node-agent/actions/runs/24457924116