Skip to content

Feature/cel const folding#789

Merged
YakirOren merged 2 commits intomainfrom
feature/cel-const-folding
Apr 23, 2026
Merged

Feature/cel const folding#789
YakirOren merged 2 commits intomainfrom
feature/cel-const-folding

Conversation

@YakirOren
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Yakir Oren <yakiroren@gmail.com>
Signed-off-by: Yakir Oren <yakiroren@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@YakirOren has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 41 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 34 minutes and 41 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6f8870e6-3975-42ad-a3f7-701a7e709d61

📥 Commits

Reviewing files that changed from the base of the PR and between c4e492f and c70b0e6.

📒 Files selected for processing (1)
  • pkg/rulemanager/cel/cel.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/cel-const-folding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Performance Benchmark Results

Node-Agent Resource Usage
Metric BEFORE AFTER Delta
Avg CPU (cores) 0.158 0.165 +4.3%
Peak CPU (cores) 0.167 0.171 +2.6%
Avg Memory (MiB) 318.347 265.033 -16.7%
Peak Memory (MiB) 324.328 270.176 -16.7%
Dedup Effectiveness (AFTER only)
Event Type Passed Deduped Ratio
capabilities 0 0 N/A
hardlink 6000 0 0.0%
http 1704 119456 98.6%
network 900 78000 98.9%
open 35878 620367 94.5%
symlink 6000 0 0.0%
syscall 972 1884 66.0%
Event Counters
Metric BEFORE AFTER
capability_counter 11 9
dns_counter 1439 1428
exec_counter 7198 7142
network_counter 94693 93967
open_counter 789115 783270
syscall_counter 3542 3496

@YakirOren YakirOren merged commit 49b1201 into main Apr 23, 2026
28 checks passed
@github-actions
Copy link
Copy Markdown

Performance Benchmark Results

Node-Agent Resource Usage
Metric BEFORE AFTER Delta
Avg CPU (cores) 0.169 0.161 -4.6%
Peak CPU (cores) 0.172 0.165 -3.9%
Avg Memory (MiB) 330.006 270.589 -18.0%
Peak Memory (MiB) 332.215 277.562 -16.5%
Dedup Effectiveness (AFTER only)
Event Type Passed Deduped Ratio
capabilities 1 0 0.0%
hardlink 6000 0 0.0%
http 1760 119402 98.5%
network 900 78001 98.9%
open 34276 621978 94.8%
symlink 6000 0 0.0%
syscall 979 1879 65.7%
Event Counters
Metric BEFORE AFTER
capability_counter 11 8
dns_counter 1429 1426
exec_counter 7151 7135
network_counter 94055 93865
open_counter 783711 781976
syscall_counter 3532 3487

entlein pushed a commit to k8sstormcenter/node-agent that referenced this pull request Apr 26, 2026
Brings in 9 upstream commits: rule-manager hot-path perf (kubescape#794),
CEL constant folding + set membership optimizers (kubescape#789),
iouring CO-RE relocation fix for kernel 6.8+ (kubescape#741),
go-ntlmssp v0.1.1 bump (kubescape#790), and matthyx fork validation (kubescape#786).

Conflict resolution:
- go.mod replaces: kept our k8sstormcenter/{inspektor-gadget,storage}
  pin (the three-forks alignment from #28); dropped upstream's
  experimental matthyx/inspektor-gadget and matthyx/ebpf replaces
  (those are temporary upstream test forks for NAUT-1252 memory work,
  not relevant to our fork stack).
- go.sum: regenerated via go mod tidy.

Build clean. Unit suite: 92 packages pass; only TestRandomxFields
fails (stale tracers.tar — explicitly ignored per prior decision).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants