feat: template consolidation, extend flow, kubeconfig by smartcat999 · Pull Request #122 · kubesphere/ksbuilder

smartcat999 · 2026-03-18T02:29:49Z

Closes kubesphere/project#7345

Release note

ksbuilder: merge createapp/createsimple into create --type; add kubeconfig, chartmuseum publish, doctor, extend flow, package dependency update; template consolidation

Summary

Addresses Issue #7345 and P2 items:

1 Merge createapp/createsimple: Replace createapp/createsimple with create --type=app|simple --from=<chart>
2 Optimize create templates: Phase 2—unify extension.yaml for app/simple via generator; Phase 3—consolidate static/README/CHANGELOG/.helmignore; add frontend-only/backend-only types
3 Kubeconfig: Add --kubeconfig persistent flag and unified resolution for publish/unpublish/template
4 Publish to chartmuseum: Add publish --target=chartmuseum with --repo, --username, --password; TLS support via --ca-bundle and --insecure-skip-tls-verify
5 Template debugging: Improve ksbuilder template error hints and examples
6 Package dependency: Default to helm dependency update when extension has dependencies; add --skip-dependency-update
P2 doctor: Add ksbuilder doctor to check Go, Helm, kubectl, ksbuilder, kubeconfig
P2 extend flow: Auto-detect existing extension in ksbuilder create; offer to add missing frontend/backend via ExtendAddFrontend/ExtendAddBackend

Test Plan

go test ./pkg/extension ./pkg/extension/generator ./cmd/...
ksbuilder create --type=standard
ksbuilder create --type=app --from=./chart.tgz
ksbuilder create --type=simple --from=./chart.tgz
ksbuilder package <dir>
ksbuilder doctor

kubesphere-prow · 2026-03-18T02:29:53Z

This PR has multiple commits, and the default merge method is: squash.
You can request commits to be merged using the label: tide/merge-method-merge

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubesphere-prow · 2026-03-18T02:29:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smartcat999
Once this PR has been reviewed and has the lgtm label, please assign redscholar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gemini-code-assist · 2026-03-18T02:30:35Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the extension creation and management workflow by consolidating template logic, introducing a declarative specification for extensions, and enhancing the 'create' command to support incremental additions of capabilities. It also improves the 'package' and 'publish' commands with new features like ChartMuseum integration and a dedicated 'doctor' command for environment validation, aiming to provide a more robust and user-friendly developer experience.

Highlights

Template Consolidation: Unified extension.yaml generation for app/simple modes via a new generator, removing redundant template files and streamlining the creation process (Phase 2 & 3).
Extended 'create' Command: The 'create' command now supports adding frontend or backend capabilities to existing extensions, and offers interactive prompts for different extension types (standard, app, simple).
Declarative Extension Specification: Introduced a .ksbuilder.yaml file and 'spec' package to define extension configurations declaratively, enabling more structured and testable extension creation.
Unified Kubeconfig Handling: Implemented a centralized kubeconfig resolution logic, making kubeconfig a persistent flag across relevant commands and removing individual flags.
ChartMuseum Publishing Support: Added functionality to publish packaged extensions directly to a ChartMuseum repository, including authentication and TLS options.
New 'doctor' Command: Introduced a 'doctor' command to check the development environment for necessary tools like Go, Helm, kubectl, and kubeconfig connectivity.
Improved Packaging: The 'package' command now includes an option to skip Helm dependency updates and uses a new internal packaging function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a major refactoring of the extension creation process, consolidating templates and introducing a declarative spec-based flow. It also adds an 'extend' feature to add capabilities to existing extensions, a 'doctor' command for environment checks, and unified kubeconfig handling. The changes are well-structured and follow the provided design document. I've found a few areas with opportunities for improvement, mainly around error handling and code duplication. Overall, this is a great enhancement to the project.

gemini-code-assist · 2026-03-18T02:34:03Z

+func (o *createOptions) run(c *cobra.Command, _ []string) error {
+	// Extend mode: if extension.yaml exists in current dir, offer to add capabilities
+	// Must run before any interactive prompts so users in existing extension dirs get extend options
+	pwd, _ := os.Getwd()


The error returned by os.Getwd() is being ignored. While it's unlikely to fail in most scenarios, it's safer to handle it. If it does fail, pwd will be an empty string, which could lead to unexpected behavior in extension.InferCapabilities("").

gemini-code-assist · 2026-03-18T02:34:03Z

+	case "app":
+		from := o.from
+		if from == "" {
+			fromPrompt := inputPromptContent{
+				text:     "Chart file path (e.g. ./demo-0.1.0.tgz)",
+				errorMsg: "Chart path can't be empty",
+			}
+			from = promptGetInput(fromPrompt)
+		}
+		return extension.CreateApp(from)
+	case "simple":
+		from := o.from
+		if from == "" {
+			fromPrompt := inputPromptContent{
+				text:     "Chart file path (e.g. ./demo-0.1.0.tgz)",
+				errorMsg: "Chart path can't be empty",
+			}
+			from = promptGetInput(fromPrompt)
+		}
+		return extension.CreateSimple(from)


The logic for getting the from path is duplicated for the "app" and "simple" cases. This can be consolidated to reduce code duplication and improve maintainability.

case "app", "simple": from := o.from if from == "" { fromPrompt := inputPromptContent{ text: "Chart file path (e.g. ./demo-0.1.0.tgz)", errorMsg: "Chart path can't be empty", } from = promptGetInput(fromPrompt) } if typ == "app" { return extension.CreateApp(from) } return extension.CreateSimple(from)

gemini-code-assist · 2026-03-18T02:34:03Z

+	if o.repo == "" {
+		return fmt.Errorf("--target=chartmuseum requires --repo=<chartmuseum URL>\nHint: e.g. --repo=http://localhost:8080")
+	}
+	pwd, _ := os.Getwd()


The error from os.Getwd() is ignored. If it fails, pwd will be an empty string, which could cause issues when joining paths later on. It's better to handle this error.

gemini-code-assist · 2026-03-18T02:34:03Z

+	}
+	defer resp.Body.Close()
+
+	body, _ := io.ReadAll(resp.Body)


The error from io.ReadAll(resp.Body) is ignored. If reading the response body fails when the status code indicates an error, the error message for the failed upload will be less informative as it will contain an empty or partial body. It's better to handle this potential error.

gemini-code-assist · 2026-03-18T02:34:03Z

+
+// ExtendAddBackend adds backend capability to an existing frontend-only extension.
+// root must contain extension.yaml, values.yaml, charts/frontend.
+func ExtendAddBackend(root string) error {


There is significant code duplication between ExtendAddBackend and ExtendAddFrontend. Much of the logic for updating extension.yaml, values.yaml, and regenerating the root Makefile is repeated. This could be refactored into smaller, reusable helper functions to improve maintainability. For example, you could have helpers for updating dependencies, updating values, and copying scaffolds.